Improve parsing of custom attributes #17
Open
+169
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add functionality to parse arbitrary custom attributes - Add referenced text to attributes with an offset and length (and text) - Keep `reading_order` and `text_style` for backwards compatibility but use camelCased version in `custom_attributes`
|
Also, for custom attribute that have an offset and length, I've added the referenced text to the attribute as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've kept the structure that
parse_custom_metadatareturns the same so that tests pass (which hopefully keeps things backwards compatible). Next to the metadata keys that were set, the full list of custom attributes is now returned undermetadata['custom_attributes'].This makes
metadata['custom_tags']obsolete, but before removing it, I want to know if @LvanWissen is okay with it (since he's likely to be the only one using it at the moment).Ideally, the custom attributes end up directly as a property of the corresponding TextLine, TextRegion or Word object. Let me know if you think that's better.