Skip to content

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Nov 12, 2025

Description

This PR makes an update to the default predicate value when evaluating guide activation url urls or patterns, where we now default to true if given only url rules or patterns with a "block" directive. If there is at least one allow rule, then we maintain the current default value/behavior of false.

Note, this PR is a requirement to supporting "exclusion" rules or patterns (as added in https://github.com/knocklabs/control/pull/6441 and https://github.com/knocklabs/control/pull/6442).

Screenshots or videos

CleanShot.2025-11-12.at.14.35.13.mp4

@linear
Copy link

linear bot commented Nov 12, 2025

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

⚠️ No Changeset found

Latest commit: 47f20ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview Comment Nov 12, 2025 7:57pm
javascript-nextjs-example Ready Ready Preview Comment Nov 12, 2025 7:57pm
javascript-slack-connect-example Ready Ready Preview Comment Nov 12, 2025 7:57pm
javascript-slack-kit-example Ready Ready Preview Comment Nov 12, 2025 7:57pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.53%. Comparing base (903fbe8) to head (47f20ea).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   65.51%   65.53%   +0.02%     
==========================================
  Files         189      189              
  Lines        7797     7803       +6     
  Branches      956      959       +3     
==========================================
+ Hits         5108     5114       +6     
  Misses       2662     2662              
  Partials       27       27              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/helpers.ts 93.02% <100.00%> (+0.34%) ⬆️

@thomaswhyyou thomaswhyyou marked this pull request as ready for review November 12, 2025 20:10
@thomaswhyyou thomaswhyyou changed the title default to true when evaluating only block url rules or patterns feat: support for guide activation url rules or patterns with block directive Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants