-
Notifications
You must be signed in to change notification settings - Fork 12
feat: support for guide activation url rules or patterns with block directive #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: support for guide activation url rules or patterns with block directive #806
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
+ Coverage 65.51% 65.53% +0.02%
==========================================
Files 189 189
Lines 7797 7803 +6
Branches 956 959 +3
==========================================
+ Hits 5108 5114 +6
Misses 2662 2662
Partials 27 27
|

Description
This PR makes an update to the default predicate value when evaluating guide activation url urls or patterns, where we now default to
trueif given only url rules or patterns with a "block" directive. If there is at least one allow rule, then we maintain the current default value/behavior offalse.Note, this PR is a requirement to supporting "exclusion" rules or patterns (as added in https://github.com/knocklabs/control/pull/6441 and https://github.com/knocklabs/control/pull/6442).
Screenshots or videos
CleanShot.2025-11-12.at.14.35.13.mp4