Drag ref count #59
Open
Drag ref count #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without capturing these events the dragenter / dragleave count gets off. This is because the moxie-shim gets placed outside the dropzone (for positioning I imagine).
Prevents multiple dragenter events from firing in IE
raytiley
force-pushed
the
drag-ref-count
branch
from
efc1c4c
to
74d210e
Compare
|
This looks good to me 👍 |
|
@raytiley Is this good to go? I'll merge and release if so~ |
|
So far our QA department has only found an issue on Edge where it doesn't allow dropping. I haven't had time to investigate yet. |
|
Thanks for the update :) |
|
@raytiley are you still using this in your app? Do you remember the result from your last inquiry regarding that last comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for discussion. This code is working much better in our app with an admittedly complicated dropzone with a bunch of elements. I haven't event looked at the tests yet.