Skip to content

fix: add .catch() to promise chains #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add .catch() to promise chains #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/(routes)/dashboard/analytics/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function AnalyticsDashboard() {
try {
const end = new Date();
const start = new Date();
start.setDate(end.getDate() - parseInt(dateRange));
start.setDate(end.getDate() - parseInt(dateRange, 10));

@codeant-ai codeant-ai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: This subtracts calendar days in local time and then sends UTC instants to an API that compares timestamps directly. Across daylight-saving transitions, the resulting window is 23 or 25 hours per day rather than exactly the selected 7, 30, or 90-day duration, causing records near the range boundary to be included or excluded unexpectedly. Compute the range using a consistent UTC duration or explicitly define the analytics window as local calendar dates. [possible bug]

Severity Level: Major ⚠️ 
- ⚠️ Analytics windows vary across daylight-saving transitions.
- ⚠️ Teacher reports misclassify boundary-date doubts.

Fix in Cursor Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** src/app/(routes)/dashboard/analytics/page.tsx
**Line:** 36:36
**Comment:**
	*Possible Bug: This subtracts calendar days in local time and then sends UTC instants to an API that compares timestamps directly. Across daylight-saving transitions, the resulting window is 23 or 25 hours per day rather than exactly the selected 7, 30, or 90-day duration, causing records near the range boundary to be included or excluded unexpectedly. Compute the range using a consistent UTC duration or explicitly define the analytics window as local calendar dates.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎


let url = `/api/teacher/analytics?startDate=${start.toISOString()}&endDate=${end.toISOString()}`;
if (selectedClassroom !== "all") {
Expand Down
4 changes: 2 additions & 2 deletions src/app/api/doubts/action/[id]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function PATCH(req: Request, { params }: { params: Promise<{ id: st
const email = user?.primaryEmailAddress?.emailAddress;

const { id } = await params;
const doubtId = parseInt(id);
const doubtId = parseInt(id, 10);

@codeant-ai codeant-ai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The permissive parseInt call accepts numeric prefixes, so a request for an identifier such as 123abc is treated as an action on doubt 123. This allows malformed route parameters to invoke like, solve, or edit operations on a real doubt; validate that the entire parameter is a valid integer before converting it. [api mismatch]

Severity Level: Major ⚠️ 
- ❌ Malformed action URLs target unintended doubts.
- ⚠️ Like, solve, and edit operations affect wrong resources.

Fix in Cursor Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** src/app/api/doubts/action/[id]/route.ts
**Line:** 25:25
**Comment:**
	*Api Mismatch: The permissive `parseInt` call accepts numeric prefixes, so a request for an identifier such as `123abc` is treated as an action on doubt `123`. This allows malformed route parameters to invoke like, solve, or edit operations on a real doubt; validate that the entire parameter is a valid integer before converting it.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎


if (isNaN(doubtId)) {
return NextResponse.json({ error: "Invalid doubt ID" }, { status: 400 });
Expand Down Expand Up @@ -320,7 +320,7 @@ export async function DELETE(req: Request, { params }: { params: Promise<{ id: s
}

const { id } = await params;
const doubtId = parseInt(id);
const doubtId = parseInt(id, 10);

@codeant-ai codeant-ai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The DELETE handler converts the route parameter to a number but never rejects NaN or other invalid values before using it in the database query. Wholly invalid IDs can therefore reach the database and produce an internal error instead of the expected 400 response, while prefixed values can target a different real doubt; apply the same strict validation used by the PATCH handler. [api mismatch]

Severity Level: Critical 🚨 
- ❌ Invalid deletion requests return server errors.
- ⚠️ Prefixed IDs can delete unintended authorized doubts.

Fix in Cursor Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** src/app/api/doubts/action/[id]/route.ts
**Line:** 323:323
**Comment:**
	*Api Mismatch: The DELETE handler converts the route parameter to a number but never rejects `NaN` or other invalid values before using it in the database query. Wholly invalid IDs can therefore reach the database and produce an internal error instead of the expected 400 response, while prefixed values can target a different real doubt; apply the same strict validation used by the PATCH handler.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎


const [doubt] = await db.select().from(doubtsTable).where(and(eq(doubtsTable.id, doubtId), isNull(doubtsTable.deletedAt))).limit(1);
if (!doubt) return NextResponse.json({ error: "Doubt not found" }, { status: 404 });
Expand Down
2 changes: 1 addition & 1 deletion src/app/api/doubts/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export async function GET(req: Request) {
try {
const user = await currentUser();
const email = user?.primaryEmailAddress?.emailAddress ?? null;
const classroomId = classroomIdStr ? parseInt(classroomIdStr) : null;
const classroomId = classroomIdStr ? parseInt(classroomIdStr, 10) : null;

@codeant-ai codeant-ai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: parseInt turns malformed classroom parameters such as 7abc into 7, and turns abc into NaN; the later truthiness check then either queries classroom 7 or falls through to the public-doubt query as though no classroom filter was supplied. This silently returns the wrong dataset instead of rejecting the invalid parameter, so use strict classroom-ID parsing and explicitly return a 400 error for invalid values. [incorrect condition logic]

Severity Level: Major ⚠️ 
- ⚠️ Classroom listings can return the wrong dataset.
- ⚠️ Invalid filters silently expose public-doubt results.

Fix in Cursor Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** src/app/api/doubts/route.ts
**Line:** 58:58
**Comment:**
	*Incorrect Condition Logic: `parseInt` turns malformed classroom parameters such as `7abc` into `7`, and turns `abc` into `NaN`; the later truthiness check then either queries classroom 7 or falls through to the public-doubt query as though no classroom filter was supplied. This silently returns the wrong dataset instead of rejecting the invalid parameter, so use strict classroom-ID parsing and explicitly return a 400 error for invalid values.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎


if (classroomId && !email) {
return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
Expand Down
Loading