fix: add radix parameter to parseInt calls - #1095
Conversation
|
Someone is attempting to deploy a commit to the Karan Mani Tripathi 's projects Team on Vercel. A member of the Team first needs to authorize it. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
gssoc'26
codeant-ai
Bot
added
the
size:XS
github-actions
Bot
removed
the
size:XS
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
|
|
||
| const { id } = await params; | ||
| const doubtId = parseInt(id); | ||
| const doubtId = parseInt(id, 10); |
There was a problem hiding this comment.
Suggestion: The identifier is parsed with parseInt, which accepts partial strings such as 12abc, negative values, and zero. A malformed path can therefore be interpreted as a different doubt ID instead of returning the invalid-ID response. Validate the entire value as a positive safe integer before querying the database. [api mismatch]
Severity Level: Major ⚠️
- ❌ Malformed PATCH paths can target unintended doubts.
- ⚠️ Invalid identifiers bypass the documented 400 response.
- ⚠️ Negative and zero identifiers reach authorization logic.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/app/api/doubts/action/[id]/route.ts
**Line:** 25:25
**Comment:**
*Api Mismatch: The identifier is parsed with `parseInt`, which accepts partial strings such as `12abc`, negative values, and zero. A malformed path can therefore be interpreted as a different doubt ID instead of returning the invalid-ID response. Validate the entire value as a positive safe integer before querying the database.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix|
|
||
| const { id } = await params; | ||
| const doubtId = parseInt(id); | ||
| const doubtId = parseInt(id, 10); |
There was a problem hiding this comment.
Suggestion: The DELETE handler passes NaN to the Drizzle integer comparison without checking it. Requests such as /api/doubts/action/not-a-number can therefore cause a database/query error and return 500 instead of the expected 400 invalid-ID response. Add the same isNaN or strict positive-integer validation used by PATCH before executing the query. [error handling]
Severity Level: Major ⚠️
- ❌ DELETE requests with malformed IDs can return HTTP 500.
- ⚠️ Invalid requests generate avoidable database errors.
- ⚠️ Clients cannot reliably distinguish malformed IDs from server failures.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/app/api/doubts/action/[id]/route.ts
**Line:** 323:323
**Comment:**
*Error Handling: The DELETE handler passes `NaN` to the Drizzle integer comparison without checking it. Requests such as `/api/doubts/action/not-a-number` can therefore cause a database/query error and return 500 instead of the expected 400 invalid-ID response. Add the same `isNaN` or strict positive-integer validation used by PATCH before executing the query.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| const user = await currentUser(); | ||
| const email = user?.primaryEmailAddress?.emailAddress ?? null; | ||
| const classroomId = classroomIdStr ? parseInt(classroomIdStr) : null; | ||
| const classroomId = classroomIdStr ? parseInt(classroomIdStr, 10) : null; |
There was a problem hiding this comment.
Suggestion: Using parseInt without validating the complete query parameter makes invalid values such as abc or 0 become a falsy classroom ID. The request then skips classroom authorization and falls through to the public-doubt query (classroomId IS NULL) instead of rejecting the malformed classroom filter. Use strict positive-integer parsing and return a 400 for invalid values. [incorrect condition logic]
Severity Level: Major ⚠️
- ⚠️ Malformed classroom filters silently change query scope.
- ⚠️ Classroom authorization is skipped for invalid values.
- ⚠️ Feed clients receive public results instead of validation errors.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/app/api/doubts/route.ts
**Line:** 58:58
**Comment:**
*Incorrect Condition Logic: Using `parseInt` without validating the complete query parameter makes invalid values such as `abc` or `0` become a falsy classroom ID. The request then skips classroom authorization and falls through to the public-doubt query (`classroomId IS NULL`) instead of rejecting the malformed classroom filter. Use strict positive-integer parsing and return a 400 for invalid values.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix1 participant
CodeAnt-AI Description
Parse numeric IDs and date ranges consistently
What Changed
Impact
✅ Reliable doubt and classroom lookups✅ Consistent analytics date ranges✅ Fewer errors from ambiguous numeric input💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.