Skip to content

fix: code quality and safety improvements - #1146

Closed
saurabhhhcodes wants to merge 1 commit into
knoxiboy:mainfrom
saurabhhhcodes:fix/DoubtDesk-95184
Closed

fix: code quality and safety improvements#1146
saurabhhhcodes wants to merge 1 commit into
knoxiboy:mainfrom
saurabhhhcodes:fix/DoubtDesk-95184

Conversation

@saurabhhhcodes

@saurabhhhcodes saurabhhhcodes commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

CodeAnt-AI Description

Restore public doubt room functionality

What Changed

  • Public rooms again display doubts with search, subject, tag, status, bookmark, and sort filters
  • Users can load additional doubts as they scroll and see pending posts while offline
  • Subject-specific rooms again show their doubts, sorting, pagination, and empty states
  • Users can open the ask-doubt form from both room views

Impact

✅ Public doubt listings remain usable
✅ Search and filtering work across rooms
✅ Users can submit doubts from room pages

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling when loading public rooms.
    • Fetch failures are now captured consistently, helping prevent silent loading issues and making problems easier to diagnose.
    • Corrected an issue that could leave error handling disconnected from the public-room loading process.

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Karan Mani Tripathi 's projects Team on Vercel.

A member of the Team first needs to authorize it.

@codeant-ai

codeant-ai Bot commented Aug 1, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR fcc9453 Aug 01, 2026 · 00:50 00:51

@codeant-ai

codeant-ai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@github-actions github-actions Bot added gssoc'26 GSSoC program issue level:intermediate Intermediate level task type:bug Bug fix labels Aug 1, 2026
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bcc20cf1-6f3f-43e7-a4b1-3ad386a40784

📥 Commits

Reviewing files that changed from the base of the PR and between 1a16173 and fcc9453.

📒 Files selected for processing (2)
  • src/app/(routes)/public-rooms/[subject]/page.tsx
  • src/app/(routes)/public-rooms/page.tsx

Walkthrough

The public-room SWR fetchers now include console error handling. The subject-page change places .catch after a completed declaration, so that handler is not attached to the fetch promise.

Changes

Public-room fetch error handling

Layer / File(s) Summary
Fetcher error logging
src/app/(routes)/public-rooms/page.tsx, src/app/(routes)/public-rooms/[subject]/page.tsx
The public-room fetcher logs rejected promises. The subject-page catch expression follows a semicolon-terminated declaration and is syntactically disconnected.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: invalid

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.5)
src/app/(routes)/public-rooms/[subject]/page.tsx

File contains syntax errors that prevent linting: Line 26: Expected a statement but instead found '.catch(err => console.error(err))'.; Line 26: expected } but instead the file ends

src/app/(routes)/public-rooms/page.tsx

File contains syntax errors that prevent linting: Line 66: Expected a statement but instead found '.catch(err => console.error(err))'.; Line 66: expected } but instead the file ends

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/app/(routes)/public-rooms/[subject]/page.tsx

Parsing error: Declaration or statement expected.

src/app/(routes)/public-rooms/page.tsx

Parsing error: Declaration or statement expected.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

We are closing this pr as it has no linking issue to it. If your is actually related to a isssue assigned to u then create a new pr and link the issue in discription.

@github-actions github-actions Bot added the invalid This doesn't seem right label Aug 1, 2026
@github-actions github-actions Bot closed this Aug 1, 2026
@github-actions github-actions Bot added size/xs size/l and removed size:XS This PR changes 0-9 lines, ignoring generated files size/xs labels Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GSSoC program issue invalid This doesn't seem right level:intermediate Intermediate level task size/l type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant