Skip to content

Memory refactor #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Memory refactor #6

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce688fb
marshalls etld_data hash for speed and memory footprint reduction
dgilperez Aug 25, 2015
18c6319
refactor etld data generation to generate the yaml and cache file on …
dgilperez Aug 25, 2015
2870537
ruby 1.8 does not have File.binread
dgilperez Aug 25, 2015
9b11b1f
remove derailed development dependency
dgilperez Aug 25, 2015
37afb31
fixes Rakefile to revert calling the data generation tool without any…
dgilperez Sep 17, 2015
458d0ce
updates data to 2015-09-15 17:22:03 +0200 and change test since .cy d…
dgilperez Sep 17, 2015
fc39210
prefers YAML.dump(content, file) to file.write content.to_yaml
dgilperez Sep 17, 2015
cb52994
prefers plain YAML to Marshall binary
dgilperez Sep 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ task :etld_data do
begin
load File.join('.', ETLD_DATA_RB)
data = ETLD_DATA_URI.read(
'If-Modified-Since' => Time.parse(DomainName::ETLD_DATA_DATE).rfc2822
'If-Modified-Since' => Time.parse(DomainName.etld_data_date).rfc2822
)
rescue LoadError, NameError
data = ETLD_DATA_URI.read
Expand All @@ -49,17 +49,11 @@ namespace :etld_data do
sh 'git', 'commit',
ETLD_DATA_FILE,
ETLD_DATA_RB,
'-m', 'Update the eTLD database to %s.' % DomainName::ETLD_DATA_DATE
'-m', 'Update the eTLD database to %s.' % DomainName.etld_data_date
end
end

file ETLD_DATA_RB => [
ETLD_DATA_FILE,
ETLD_DATA_RB + '.erb',
'tool/gen_etld_data.rb'
] do
ruby 'tool/gen_etld_data.rb'
end
ruby 'tool/gen_etld_data.rb'
Copy link
Owner

@knu knu Sep 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bare command outside of any task?

Copy link
Author

@dgilperez dgilperez Sep 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess I did not understand completely the previous implementation. Changing that now to revert that.


require 'rake/testtask'
Rake::TestTask.new(:test) do |test|
Expand Down
1 change: 1 addition & 0 deletions domain_name.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Suffix List.

gem.add_runtime_dependency("unf", ["< 1.0.0", ">= 0.0.5"])
gem.add_development_dependency("test-unit", "~> 2.5.5")

if RUBY_VERSION >= "1.9"
gem.add_development_dependency("shoulda", ">= 0")
else
Expand Down
Binary file added lib/cache/etld
View file
Open in desktop
Binary file not shown.
Loading