Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire format: omit the inner type tag empty slices and arrays #929

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

wire format: omit the inner type tag empty slices and arrays #929

wants to merge 3 commits into from

Conversation

jordens
Copy link

@jordens jordens commented Jan 31, 2025

  • Wire format bump

@jordens jordens mentioned this pull request Jan 31, 2025
Closed
@jordens
defmt: shorten fmt_slice()
e6b6f58 
Rely on fmt_array for the bulk formatting.
This gives the compiler a bit more to play with for inlining and/or
code size reduction.
@jordens
decoder: slice: stick with the known vec capacity
405dd3c
@jonathanpallant
Copy link
Contributor

This looks OK but it needs a wire-format bump so we need to wait until after 1.0 is released, when we have a bunch of stuff to wrap up into Wire Format Version 5.

@jonathanpallant jonathanpallant added this to the Wire Format Version 5 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Wire Format Version 5
Development

Successfully merging this pull request may close these issues.
2 participants
@jordens @jonathanpallant