-
Notifications
You must be signed in to change notification settings - Fork 7.4k
feat(climate): add WMO normals seeding and CO2 monitoring #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3602084
feat(climate): add WMO normals seeding and CO2 monitoring
FayezBast 3390944
fix(climate): skip missing normals per-zone and align anomaly tooltip…
FayezBast 7bfcb33
fix(climate): remove normals from bootstrap and harden health/cache k…
FayezBast 5f92077
feat(climate): version anomaly cache to v2, harden seed freshness, an…
FayezBast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"components":{"schemas":{"ClimateAnomaly":{"description":"ClimateAnomaly represents a temperature or precipitation deviation from historical norms.\n Sourced from Open-Meteo / ERA5 reanalysis data.","properties":{"location":{"$ref":"#/components/schemas/GeoCoordinates"},"period":{"description":"Time period covered (e.g., \"2024-W03\", \"2024-01\").","minLength":1,"type":"string"},"precipDelta":{"description":"Precipitation deviation from normal as a percentage.","format":"double","type":"number"},"severity":{"description":"AnomalySeverity represents the severity of a climate anomaly.\n Maps to existing TS union: 'normal' | 'moderate' | 'extreme'.","enum":["ANOMALY_SEVERITY_UNSPECIFIED","ANOMALY_SEVERITY_NORMAL","ANOMALY_SEVERITY_MODERATE","ANOMALY_SEVERITY_EXTREME"],"type":"string"},"tempDelta":{"description":"Temperature deviation from normal in degrees Celsius.","format":"double","type":"number"},"type":{"description":"AnomalyType represents the type of climate anomaly.\n Maps to existing TS union: 'warm' | 'cold' | 'wet' | 'dry' | 'mixed'.","enum":["ANOMALY_TYPE_UNSPECIFIED","ANOMALY_TYPE_WARM","ANOMALY_TYPE_COLD","ANOMALY_TYPE_WET","ANOMALY_TYPE_DRY","ANOMALY_TYPE_MIXED"],"type":"string"},"zone":{"description":"Climate zone name (e.g., \"Northern Europe\", \"Sahel\").","minLength":1,"type":"string"}},"required":["zone","period"],"type":"object"},"Error":{"description":"Error is returned when a handler encounters an error. It contains a simple error message that the developer can customize.","properties":{"message":{"description":"Error message (e.g., 'user not found', 'database connection failed')","type":"string"}},"type":"object"},"FieldViolation":{"description":"FieldViolation describes a single validation error for a specific field.","properties":{"description":{"description":"Human-readable description of the validation violation (e.g., 'must be a valid email address', 'required field missing')","type":"string"},"field":{"description":"The field path that failed validation (e.g., 'user.email' for nested fields). For header validation, this will be the header name (e.g., 'X-API-Key')","type":"string"}},"required":["field","description"],"type":"object"},"GeoCoordinates":{"description":"GeoCoordinates represents a geographic location using WGS84 coordinates.","properties":{"latitude":{"description":"Latitude in decimal degrees (-90 to 90).","format":"double","maximum":90,"minimum":-90,"type":"number"},"longitude":{"description":"Longitude in decimal degrees (-180 to 180).","format":"double","maximum":180,"minimum":-180,"type":"number"}},"type":"object"},"ListClimateAnomaliesRequest":{"description":"ListClimateAnomaliesRequest specifies filters for retrieving climate anomaly data.","properties":{"cursor":{"description":"Cursor for next page.","type":"string"},"minSeverity":{"description":"AnomalySeverity represents the severity of a climate anomaly.\n Maps to existing TS union: 'normal' | 'moderate' | 'extreme'.","enum":["ANOMALY_SEVERITY_UNSPECIFIED","ANOMALY_SEVERITY_NORMAL","ANOMALY_SEVERITY_MODERATE","ANOMALY_SEVERITY_EXTREME"],"type":"string"},"pageSize":{"description":"Maximum items per page (1-100).","format":"int32","type":"integer"}},"type":"object"},"ListClimateAnomaliesResponse":{"description":"ListClimateAnomaliesResponse contains the list of climate anomalies.","properties":{"anomalies":{"items":{"$ref":"#/components/schemas/ClimateAnomaly"},"type":"array"},"pagination":{"$ref":"#/components/schemas/PaginationResponse"}},"type":"object"},"PaginationResponse":{"description":"PaginationResponse contains pagination metadata returned alongside list results.","properties":{"nextCursor":{"description":"Cursor for fetching the next page. Empty string indicates no more pages.","type":"string"},"totalCount":{"description":"Total count of items matching the query, if known. Zero if the total is unknown.","format":"int32","type":"integer"}},"type":"object"},"ValidationError":{"description":"ValidationError is returned when request validation fails. It contains a list of field violations describing what went wrong.","properties":{"violations":{"description":"List of validation violations","items":{"$ref":"#/components/schemas/FieldViolation"},"type":"array"}},"required":["violations"],"type":"object"}}},"info":{"title":"ClimateService API","version":"1.0.0"},"openapi":"3.1.0","paths":{"/api/climate/v1/list-climate-anomalies":{"get":{"description":"ListClimateAnomalies retrieves temperature and precipitation anomalies from ERA5 data.","operationId":"ListClimateAnomalies","parameters":[{"description":"Maximum items per page (1-100).","in":"query","name":"page_size","required":false,"schema":{"format":"int32","type":"integer"}},{"description":"Cursor for next page.","in":"query","name":"cursor","required":false,"schema":{"type":"string"}},{"description":"Optional filter by anomaly severity.","in":"query","name":"min_severity","required":false,"schema":{"type":"string"}}],"responses":{"200":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/ListClimateAnomaliesResponse"}}},"description":"Successful response"},"400":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/ValidationError"}}},"description":"Validation error"},"default":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/Error"}}},"description":"Error response"}},"summary":"ListClimateAnomalies","tags":["ClimateService"]}}}} | ||
| {"components":{"schemas":{"ClimateAnomaly":{"description":"ClimateAnomaly represents a temperature or precipitation deviation from historical norms.\n Sourced from Open-Meteo / ERA5 reanalysis data.","properties":{"location":{"$ref":"#/components/schemas/GeoCoordinates"},"period":{"description":"Time period covered (e.g., \"2024-W03\", \"2024-01\").","minLength":1,"type":"string"},"precipDelta":{"description":"Precipitation deviation from normal in millimeters.","format":"double","type":"number"},"severity":{"description":"AnomalySeverity represents the severity of a climate anomaly.\n Maps to existing TS union: 'normal' | 'moderate' | 'extreme'.","enum":["ANOMALY_SEVERITY_UNSPECIFIED","ANOMALY_SEVERITY_NORMAL","ANOMALY_SEVERITY_MODERATE","ANOMALY_SEVERITY_EXTREME"],"type":"string"},"tempDelta":{"description":"Temperature deviation from normal in degrees Celsius.","format":"double","type":"number"},"type":{"description":"AnomalyType represents the type of climate anomaly.\n Maps to existing TS union: 'warm' | 'cold' | 'wet' | 'dry' | 'mixed'.","enum":["ANOMALY_TYPE_UNSPECIFIED","ANOMALY_TYPE_WARM","ANOMALY_TYPE_COLD","ANOMALY_TYPE_WET","ANOMALY_TYPE_DRY","ANOMALY_TYPE_MIXED"],"type":"string"},"zone":{"description":"Climate zone name (e.g., \"Northern Europe\", \"Sahel\").","minLength":1,"type":"string"}},"required":["zone","period"],"type":"object"},"Co2DataPoint":{"properties":{"anomaly":{"format":"double","type":"number"},"month":{"type":"string"},"ppm":{"format":"double","type":"number"}},"type":"object"},"Co2Monitoring":{"properties":{"annualGrowthRate":{"format":"double","type":"number"},"currentPpm":{"format":"double","type":"number"},"measuredAt":{"format":"int64","type":"string"},"methanePpb":{"format":"double","type":"number"},"monthlyAverage":{"format":"double","type":"number"},"nitrousOxidePpb":{"format":"double","type":"number"},"preIndustrialBaseline":{"format":"double","type":"number"},"station":{"type":"string"},"trend12m":{"items":{"$ref":"#/components/schemas/Co2DataPoint"},"type":"array"},"yearAgoPpm":{"format":"double","type":"number"}},"type":"object"},"Error":{"description":"Error is returned when a handler encounters an error. It contains a simple error message that the developer can customize.","properties":{"message":{"description":"Error message (e.g., 'user not found', 'database connection failed')","type":"string"}},"type":"object"},"FieldViolation":{"description":"FieldViolation describes a single validation error for a specific field.","properties":{"description":{"description":"Human-readable description of the validation violation (e.g., 'must be a valid email address', 'required field missing')","type":"string"},"field":{"description":"The field path that failed validation (e.g., 'user.email' for nested fields). For header validation, this will be the header name (e.g., 'X-API-Key')","type":"string"}},"required":["field","description"],"type":"object"},"GeoCoordinates":{"description":"GeoCoordinates represents a geographic location using WGS84 coordinates.","properties":{"latitude":{"description":"Latitude in decimal degrees (-90 to 90).","format":"double","maximum":90,"minimum":-90,"type":"number"},"longitude":{"description":"Longitude in decimal degrees (-180 to 180).","format":"double","maximum":180,"minimum":-180,"type":"number"}},"type":"object"},"GetCo2MonitoringRequest":{"type":"object"},"GetCo2MonitoringResponse":{"properties":{"monitoring":{"$ref":"#/components/schemas/Co2Monitoring"}},"type":"object"},"ListClimateAnomaliesRequest":{"description":"ListClimateAnomaliesRequest specifies filters for retrieving climate anomaly data.","properties":{"cursor":{"description":"Cursor for next page.","type":"string"},"minSeverity":{"description":"AnomalySeverity represents the severity of a climate anomaly.\n Maps to existing TS union: 'normal' | 'moderate' | 'extreme'.","enum":["ANOMALY_SEVERITY_UNSPECIFIED","ANOMALY_SEVERITY_NORMAL","ANOMALY_SEVERITY_MODERATE","ANOMALY_SEVERITY_EXTREME"],"type":"string"},"pageSize":{"description":"Maximum items per page (1-100).","format":"int32","type":"integer"}},"type":"object"},"ListClimateAnomaliesResponse":{"description":"ListClimateAnomaliesResponse contains the list of climate anomalies.","properties":{"anomalies":{"items":{"$ref":"#/components/schemas/ClimateAnomaly"},"type":"array"},"pagination":{"$ref":"#/components/schemas/PaginationResponse"}},"type":"object"},"PaginationResponse":{"description":"PaginationResponse contains pagination metadata returned alongside list results.","properties":{"nextCursor":{"description":"Cursor for fetching the next page. Empty string indicates no more pages.","type":"string"},"totalCount":{"description":"Total count of items matching the query, if known. Zero if the total is unknown.","format":"int32","type":"integer"}},"type":"object"},"ValidationError":{"description":"ValidationError is returned when request validation fails. It contains a list of field violations describing what went wrong.","properties":{"violations":{"description":"List of validation violations","items":{"$ref":"#/components/schemas/FieldViolation"},"type":"array"}},"required":["violations"],"type":"object"}}},"info":{"title":"ClimateService API","version":"1.0.0"},"openapi":"3.1.0","paths":{"/api/climate/v1/get-co2-monitoring":{"get":{"description":"GetCo2Monitoring retrieves seeded NOAA greenhouse gas monitoring data.","operationId":"GetCo2Monitoring","responses":{"200":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/GetCo2MonitoringResponse"}}},"description":"Successful response"},"400":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/ValidationError"}}},"description":"Validation error"},"default":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/Error"}}},"description":"Error response"}},"summary":"GetCo2Monitoring","tags":["ClimateService"]}},"/api/climate/v1/list-climate-anomalies":{"get":{"description":"ListClimateAnomalies retrieves temperature and precipitation anomalies from ERA5 data.","operationId":"ListClimateAnomalies","parameters":[{"description":"Maximum items per page (1-100).","in":"query","name":"page_size","required":false,"schema":{"format":"int32","type":"integer"}},{"description":"Cursor for next page.","in":"query","name":"cursor","required":false,"schema":{"type":"string"}},{"description":"Optional filter by anomaly severity.","in":"query","name":"min_severity","required":false,"schema":{"type":"string"}}],"responses":{"200":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/ListClimateAnomaliesResponse"}}},"description":"Successful response"},"400":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/ValidationError"}}},"description":"Validation error"},"default":{"content":{"application/json":{"schema":{"$ref":"#/components/schemas/Error"}}},"description":"Error response"}},"summary":"ListClimateAnomalies","tags":["ClimateService"]}}}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
climateZoneNormalsdouble-registered: BOOTSTRAP_KEYS + STANDALONE_KEYSclimateZoneNormalsis being registered in bothBOOTSTRAP_KEYS(line ~32) andSTANDALONE_KEYS(line ~87). This causes two problems:Duplicate health check — the health module iterates both maps independently, so
climate:zone-normals:v1will be checked twice in every health report, potentially double-counting failures.Bootstrap response inflation — because the key is also in
BOOTSTRAP_KEYS(andBOOTSTRAP_CACHE_KEYSinbootstrap.js), the full normals payload (22 zones × 12 monthly normals) is included in every bootstrap response sent to browser clients, even though there is no frontend consumer (climateZoneNormalsis explicitly inPENDING_CONSUMERSinbootstrap.test.mjs).Since zone normals are a backend-only baseline consumed directly by seed scripts via Redis, they have no business being in the bootstrap pipeline at all. The key should live only in
STANDALONE_KEYS, andclimateZoneNormalsshould be removed fromBOOTSTRAP_KEYSin this file, fromBOOTSTRAP_CACHE_KEYSinapi/bootstrap.js, and fromBOOTSTRAP_CACHE_KEYS/BOOTSTRAP_TIERSinserver/_shared/cache-keys.ts.