Skip to content

revert: climate disasters (#2535) — accidental merge#2544

Merged
koala73 merged 1 commit intomainfrom
revert/pr-2535-climate-disasters
Mar 30, 2026
Merged

revert: climate disasters (#2535) — accidental merge#2544
koala73 merged 1 commit intomainfrom
revert/pr-2535-climate-disasters

Conversation

@koala73
Copy link
Copy Markdown
Owner

@koala73 koala73 commented Mar 30, 2026

Reverts #2535 which was merged accidentally.

The feature is not lost — the branch and commits still exist and the PR can be re-opened when ready. Before merging again, RELIEFWEB_APPNAME must be set on the Railway climate-disasters cron service or the seeder will crash on every run.

…ers RPC with snake_case Redis payload (#2535)"

This reverts commit e2dea94.
@mintlify
Copy link
Copy Markdown

mintlify bot commented Mar 30, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
WorldMonitor 🟢 Ready View Preview Mar 30, 2026, 9:08 AM

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
worldmonitor Ignored Ignored Mar 30, 2026 9:07am

Request Review

@koala73 koala73 merged commit ae4010a into main Mar 30, 2026
9 checks passed
@koala73 koala73 deleted the revert/pr-2535-climate-disasters branch March 30, 2026 09:09
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 30, 2026

Greptile Summary

This PR reverts the accidentally-merged climate disasters feature (#2535), cleanly removing all associated code across 20 files: the ReliefWeb + GDACS seed script, the ListClimateDisasters proto/RPC/handler stack, generated client and server stubs, bootstrap hydration wiring, health/seed monitoring keys, OpenAPI specs, and tests. The feature branch and commits are preserved, and the PR description correctly documents the prerequisite (RELIEFWEB_APPNAME env var on the Railway cron service) that must be satisfied before re-merging.

Key changes:

  • Deletes scripts/seed-climate-disasters.mjs (the fetcher that would crash without RELIEFWEB_APPNAME)
  • Removes climate:disasters:v1 from bootstrap, health, seed-health, cache-keys, gateway, and MCP tool config
  • Deletes proto definitions (climate_disaster.proto, list_climate_disasters.proto) and the server handler (list-climate-disasters.ts)
  • Strips disaster types and the listClimateDisasters method from both generated client and server stubs
  • Removes getHydratedClimateDisasters() accessor from src/services/climate/index.ts
  • Deletes tests/climate-disasters-seed.test.mjs and the corresponding TTL guard test

Scope check: A codebase-wide search for residual climateDisasters/climate:disasters/ClimateDisaster references found only docs/climate-variant-full.md, which pre-dates this feature (added in #2466) and serves as a planning reference document — its contents are intentionally forward-looking and do not affect runtime behavior.

Confidence Score: 5/5

Clean, comprehensive revert with no dangling code references — safe to merge immediately.

All 20 changed files are pure removals with no logic errors. Every surface touched by the original feature has been symmetrically unwound. No residual runtime references found. No P0 or P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
scripts/seed-climate-disasters.mjs Entire 467-line seed script deleted; was the ReliefWeb + GDACS fetcher that crashed without RELIEFWEB_APPNAME set.
server/worldmonitor/climate/v1/list-climate-disasters.ts Entire 93-line cache-read RPC handler deleted; was reading climate:disasters:v1 with cursor-based pagination.
src/generated/server/worldmonitor/climate/v1/service_server.ts Removes disaster types, handler interface method, and the GET route descriptor from generated server stubs.
proto/worldmonitor/climate/v1/climate_disaster.proto 35-line proto message definition deleted as part of complete service removal.
api/bootstrap.js Removes climateDisasters from BOOTSTRAP_CACHE_KEYS and SLOW_KEYS — clean removal.
server/_shared/cache-keys.ts Removes climateDisasters cache key and slow tier entry from both lookup maps.
tests/climate-disasters-seed.test.mjs 175-line test file deleted along with its source module — correctly removes orphaned tests.

Reviews (1): Last reviewed commit: "Revert "feat(climate): add climate disas..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant