get_feature_names_out for EstimatorTransformer
#539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MBrouns <[email protected]>
Co-authored-by: MBrouns <[email protected]>
CarloLepelaars
changed the title
get_feature_names_out for Meta estimatorsget_feature_names_out for EstimatorTransformer
koaning
reviewed
Oct 6, 2022
koaning
approved these changes
Oct 6, 2022
|
Hey, yes this feature is ready and meant to be reviewed. I'll make sure to add [WIP] if something would be still work in progress As for the commits there are some commits here that are already merged to scikit-lego from a previous PR, but somehow it still shows when I create a new local branch. Everything up to commit #f06a7af is duplicate. Do you know how we can clean up the commit history? Otherwise I think we are ready to merge! Fixed the minor nitpicks. |
13 tasks
|
@koaning, shall we go ahead and merge this one to |
4 tasks
koaning
reviewed
Nov 4, 2022
koaning
reviewed
Nov 4, 2022
koaning
requested changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
get_feature_names_outfunctionality forEstimatorTransformer. This is a desirable method forEstimatorTransformerbecause its output is used as input for a subsequent estimator.get_feature_names_outforEstimatorTransformer.get_feature_names_outworks with aFeatureUnioncomponent.get_feature_names_outimplementation is necessary and desired for other Meta estimators.@koaning I think it is not necessary to implement
get_feature_names_outfor the other estimators insklego.meta, because it seems all these estimators are used as the last component in aPipeline, except forEstimatorTransformer.EstimatorTransformerwill often be a component somewhere in the middle of aPipelineand thereforeget_feature_names_outis desirable. That said I'm happy to work on other implementations ofget_feature_names_outinsklego.metaif you disagree with this reasoning.Solves Issue #533