-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update colors #5033
Merged
Merged
Update colors #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-red, remove duplicated react-tagsinput.scss lines, update all the code to match colors after update
# Conflicts: # jsapp/scss/libs/react-tagsinput.scss
7 tasks
…to update-colors
to avoid problems when we update color values and name doesn't make sense anymore
duvld
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick look around the UI and it looks like your find and replace got all of them :) if someone spots a missed spot we can probably do individual touch ups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
We've updated most of the colors in our palette to more accessible shades, and added few new colors in preparation for upcoming improvements.
Notes
Most of the colors were slightly updated. We had a major change in reds:
kobo-red
was renamed tokobo-mid-red
kobo-dark-red
was renamed tokobo-red
(this is the part that might be confusing)kobo-dark-red
that is slightly darkerAnother big change was with grays:
kobo-gray-<lightness number>
were renamed tokobo-neutral-<counter>
, e.g.kobo-gray-98
is nowkobo-neutral-100
-100
,-200
,-300
, …,-900
as neutral color "types". This allows us to have flexibility of adding-250
in future if neededOther changes here:
dark-red
tored
(this is kinda undoing recent change, but previous change Updatered
Buttons to usedark-red
for accessibility #4993 was changing the color to darker shade, this one keeps the color, but the name is different)red
tomid-red
react-tagsinput.scss
file (I'm pretty sure I already did that)kobo-red
(so will be darker than previously), and some were updated to bekobo-mid-red
(so will appear as if nothing changed)Related issues
Followup to #4993
Made kobotoolbox/docs#372