Limit Celery Beat event updates on bulk trash-bin actions #5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restricts the number of Celery Beat event updates triggered during bulk actions within the trash bin. By reducing the frequency of updates, we prevent the stacking of multiple updates that can create a domino effect, leading to a bottleneck.
This allows projects to be deleted without delays and helps to prevent 504-Timeout errors.
Notes
Use a context manager to disconnect and reconnect Celery Beat signals on save and delete.
Only update Celery Beat event scheduler if it has not been updated for the last 5 minutes.