-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pull request template #5221
Conversation
Preview of the template: 🗒️ Checklist
📣 Summary📖 Description👷 Description for instance maintainers👀 Preview stepsBug template:
Feature/no-change template:
💭 Notes |
My only concern about the template is the emoji in the summary. This shouldn't be a blocker, but updating the python scripts to recognize the emoji might be a bit tricky |
@JacquelineMorrissette , it should not be a problem. Type "help", "copyright", "credits" or "license" for more information.
>>> s = '📖 '
>>> s == '📖 '
True |
I picked on #5113 just to try it but I can't seem to get it to work with the release notes script:
What I was expecting: What I got: |
Like I said, it shouldn't be a blocker, but I'm probably going to need some help to get the scripts working again |
@JacquelineMorrissette I see a typo in your script ( |
It's not a typo, I picked an emoji just to test. It matches the emoji I added to the description heading in #5113 |
Nit: can we not delete the checklist after? I find it useful to keep it around |
@rgraber good point, to allow to check-uncheck-check things as one works forth-n-back with reviewers. Loosened the last checklist item to "delete this section before merging" |
💭 Notes
See the new Pull Request process here.