New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exchange header order and replace pcl_isfinite with std::isfinite #32

Merged

koide3 merged 1 commit into koide3:master from lixin-Lee:exchange_header_order_and_replace_pcl_isfinite

Jul 9, 2021

Contributor

lixin-Lee commented Jul 7, 2021

This PR do these things:

<pcl/pcl_macros.h> should be included before <pcl/filters/boost.h>, or some errors may occur

pcl/filters/boost.h:46:22: error: expected constructor, destructor, or type conversion before ‘(’ token PCL_DEPRECATED_HEADER(1, 15, "Please include the needed boost headers directly.")

replace pcl_isfinite with std::isfinite, solve catkin_make error #8

Current setup:
Ubuntu 18.04
PCL: 1.11


          exchange header order and replace pcl_isfinite with std::isfinite

906421a

Owner

koide3 commented Jul 9, 2021

Looks good. Thanks for your PR!

koide3 merged commit 3ad0aa6 into koide3:master

h-ohta mentioned this pull request

suppress warnings tier4/ndt_omp#3

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet