Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: Set versions as minimum instead of hardcoding as exact #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

C0rn3j
Copy link

@C0rn3j C0rn3j commented Nov 18, 2024

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
librespot 0.0.9 requires requests==2.30.0, but you have requests 2.32.3 which is incompatible.

If there turns out to be an issue later, it can be hardcoded as minimum + maximum.

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
librespot 0.0.9 requires requests==2.30.0, but you have requests 2.32.3 which is incompatible.

The way it is set at the moment breaks installing the project if newer versions need to be installed.

@kokarare1212
Copy link
Owner

Looks good.
However, only protobuf needs to match the version due to compatibility issues.

@kokarare1212
Copy link
Owner

Also, in general, ~= is better for major updates of libraries, as compatibility may be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants