Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document completion queries for execution spaces #368

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Document completion queries for execution spaces #368

wants to merge 2 commits into from

Conversation

masterleinad
Copy link
Contributor

dalg24
dalg24 previously requested changes May 18, 2023
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally pushed documentation for printf

@masterleinad masterleinad requested a review from dalg24 May 18, 2023 21:14
@masterleinad
Copy link
Contributor Author

You accidentally pushed documentation for printf

Fixed.

@dalg24 dalg24 dismissed their stale review May 18, 2023 21:15

was fixed

@masterleinad masterleinad mentioned this pull request May 19, 2023
Draft
ajpowelsnl
ajpowelsnl approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ajpowelsnl
ajpowelsnl reviewed Jun 13, 2023
View reviewed changes
docs/source/API/core/execution_spaces.rst
@@ -313,6 +313,8 @@ Functions

* ``const char* name() const;``: *Returns* the label of the execution space instance.

* ``bool is_running() const;``: *Returns* ``true`` if the execution space is currently executing a kernel, otherwise returns ``false``. Therefore, if the function returns ``false``, all kernels submitted by the current thread have been completed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group comment:

  • Revisit once code PR finalized

dalg24
dalg24 requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Reacting to the agenda for the documentation session next Tuesday, Jan 16th)
This is NOT ready to merge. The work it is documenting is a draft PR and has not been merged

@masterleinad masterleinad marked this pull request as draft January 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpowelsnl ajpowelsnl ajpowelsnl approved these changes

@dalg24 dalg24 dalg24 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masterleinad @dalg24 @ajpowelsnl