Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdalgos (3/10): team-level API, and rst update for release 4.2 #371

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

stdalgos (3/10): team-level API, and rst update for release 4.2 #371

wants to merge 11 commits into from

Conversation

fnrizzi
Copy link
Collaborator

@fnrizzi fnrizzi commented May 3, 2023 •
edited
Loading 

Kokkos_ForEach.hpp
Kokkos_ForEachN.hpp
Kokkos_Search.hpp
Kokkos_SearchN.hpp
Kokkos_LexicographicalCompare.hpp
Kokkos_Mismatch.hpp

Open individual html with Firefox (must be firefox or it won't display correctly) Archive.zip

@fnrizzi fnrizzi marked this pull request as draft May 3, 2023 15:39
@fnrizzi fnrizzi changed the title progress: for_each and for_each_n std_algos: part 3/10: add team-level API and convert to rst May 3, 2023
@fnrizzi fnrizzi mentioned this pull request May 15, 2023
Open
@fnrizzi fnrizzi mentioned this pull request May 23, 2023
Closed
@fnrizzi fnrizzi changed the title std_algos: part 3/10: add team-level API and convert to rst std_algos: part 3/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED) Jun 13, 2023
This was referenced Aug 10, 2023
Merged
Merged
@fnrizzi
progress: for_each and for_each_n
31c4c18 
todo to finish this PR:

LexicographicalCompare
Mismatch
Search
SearchN
@fnrizzi
search
cc03c20
@fnrizzi
update search_n
7c66852
@fnrizzi fnrizzi marked this pull request as ready for review September 27, 2023 10:24
@fnrizzi fnrizzi changed the title std_algos: part 3/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED) stdalgos (3/N): team-level API, and rst update for release 4.2 Sep 27, 2023
@fnrizzi fnrizzi changed the title stdalgos (3/N): team-level API, and rst update for release 4.2 stdalgos (3/10): team-level API, and rst update for release 4.2 Dec 10, 2023
ajpowelsnl
ajpowelsnl requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fnrizzi - apologies for the delay in reviewing. @crtrott and I are working on getting these entries merged.

docs/source/API/algorithms/std-algorithms/all/StdForEach.rst Outdated Show resolved Hide resolved
docs/source/API/algorithms/std-algorithms/all/StdMismatch.rst Outdated Show resolved Hide resolved
@dalg24
Copy link
Member

dalg24 commented Jul 31, 2024

Please resolve the conflicts. Francesco if you are not able to get to it just say so, we can assign someone else.

@fnrizzi
Copy link
Collaborator Author

fnrizzi commented Jul 31, 2024

I am away until next week, best if you assign someone else

@dalg24
Copy link
Member

dalg24 commented Jul 31, 2024

@ajpowelsnl would you be able to handle the conflicts resolution?

@ajpowelsnl
Copy link
Contributor

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

@crtrott crtrott crtrott approved these changes

@ajpowelsnl ajpowelsnl ajpowelsnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fnrizzi @dalg24 @ajpowelsnl @crtrott