Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing pytorch tensors directly to kernel calls #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NaderAlAwar
Copy link
Contributor

This checks if torch is installed and uses torch.is_tensor() to check if the passed argument is a pytorch tensor.

@NaderAlAwar NaderAlAwar mentioned this pull request Jul 7, 2024
@gliga
Copy link
Contributor

gliga commented Jul 9, 2024

If torch is not available, will it print a user friendly error message?

@NaderAlAwar
Copy link
Contributor Author

Not at the moment but this is not restricted to PyTorch. We need to have better error messages for invalid arguments passed to kernels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants