This repository has been archived by the owner on May 23, 2024. It is now read-only.
SIMD unittests [WIP] #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobDomagala
force-pushed
the
add-unit-tests
branch
from
8f17c6f
to
f1b9670
Compare
JacobDomagala
force-pushed
the
add-unit-tests
branch
from
f1b9670
to
1c7eda9
Compare
Refactored a little bit.
Done only all basics methods.
|
Unit tests need to work on:
|
7 tasks
fnrizzi
reviewed
Sep 20, 2021
test/TestMath.cpp
Outdated
|
|
||
| // Methods to create data | ||
| template<class ValueType> | ||
| Kokkos::View<simd_t<ValueType> *> create_data_with_uniq_value(std::string name, int size, ValueType value) { |
There was a problem hiding this comment.
I would change a bit the names here to be more explicit about what we are creating, something like:
create_view_with_unique_value
fnrizzi
reviewed
Sep 20, 2021
test/TestMath.cpp
Outdated
| } | ||
|
|
||
| template<class ValueType> | ||
| Kokkos::View<simd_t<ValueType> *> create_data_zero_to_size_positive(std::string name, int size, SIMD_CONSTRUCTOR constructor = SIMD_CONSTRUCTOR_SCALAR) { |
There was a problem hiding this comment.
improve name because If I read this, I would not get what "positive" means
fnrizzi
reviewed
Sep 20, 2021
test/TestMath.cpp
Outdated
| } | ||
|
|
||
| template<class ValueType> | ||
| Kokkos::View<simd_t<ValueType> *> create_data_zero_to_size_negative(std::string name, int size, SIMD_CONSTRUCTOR constructor = SIMD_CONSTRUCTOR_SCALAR) { |
fnrizzi
reviewed
Sep 20, 2021
test/TestMath.cpp
Outdated
| } | ||
|
|
||
| template<class ValueType> | ||
| Kokkos::View<simd_t<ValueType> *> create_data_sqrt(std::string name, int size, SIMD_CONSTRUCTOR constructor = SIMD_CONSTRUCTOR_SCALAR) { |
There was a problem hiding this comment.
"create_data_sqrt" what does this mean? if this a helper function needed to test the sqrt, then we could use:
create_view_for_sqrt_test
otherwise, if we chose a more general name, the name should express how you fill it
fnrizzi
reviewed
Sep 20, 2021
test/TestMath.cpp
Outdated
| } | ||
|
|
||
| template<class ValueType> | ||
| Kokkos::View<simd_t<ValueType> *> create_data_cbrt(std::string name, int size, SIMD_CONSTRUCTOR constructor = SIMD_CONSTRUCTOR_SCALAR) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to NexGenAnalytics#1
TODO: