Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toying with twig #34

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Toying with twig #34

wants to merge 19 commits into from

Conversation

bumpux
Copy link

@bumpux bumpux commented Feb 7, 2012

Hey there. I really like the new changes and am getting to know them a bit.

Exploring the Twig docs I came on the "extends" tag and thought I'd attempt a slight restructure on my Stacey fork:

  • new directory (templates/base) includes base.twig. Kind of a meta-template. It includes the outer html skeleton and blocks for title, content and footer.
  • Blocks in a .twig can be inherited and-or extended by the revised default.html, page.html. and project.html.

I wonder if you thought of this approach already? In any case I thought you might like to take a look.

@kolber
Copy link
Owner

kolber commented Feb 8, 2012

I was actually just playing around with this the other day. It's really powerful.
My only concern is that template inheritance might confuse the more non-technical users if we put it in the default template. What are your thoughts?

@bumpux
Copy link
Author

bumpux commented Feb 10, 2012

I see your point that it may intimidate some users or overcomplicate
the default. Twig has a lot more power/complexity beyond extending
templates, which more adventurous users can explore (assuming you're
including access to all of Twig's feature set). So now that I think
about it maybe this doesn't belong in the default template. But a new
alternate template showing this feature could be valuable. I'm hoping
to be ready to submit such a thing pretty soon for your evaluation,
hopefully including some responsive design elements too ...

On Wed, Feb 8, 2012 at 3:32 PM, Anthony Kolber
[email protected]
wrote:

I was actually just playing around with this the other day. It's really powerful.
My only concern is that template inheritance might confuse the more non-technical users if we put it in the default template. What are your thoughts?


Reply to this email directly or view it on GitHub:
#34 (comment)

@kolber
Copy link
Owner

kolber commented Feb 10, 2012

Yea, I think that would be the perfect approach.
Looking forward to seeing what you come up with!

@gregcoleinfo
Copy link

I would love to see a template with advanced twig functionality, it would be a great learning tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants