Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Twig to 1.13.1 #91

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Upgrade Twig to 1.13.1 #91

wants to merge 4 commits into from

Conversation

itskingori
Copy link
Contributor

@itskingori
Upgrade Twig to 1.13.1 (update files)
9442884
@itskingori
Rename Autoloader to Autoloader.inc.php
e8ec408
@itskingori
Port old stacey specific additions
d07a366
@itskingori
Get rid of "Attribute callable does not exist for Node"
3ebe715 
- Not sure if this is recommended though, I just know it gets rid of
the error
- Occurs if one has something like this {% set page = get('/pages') %}
@itskingori itskingori mentioned this pull request Jun 11, 2013
Open
@mjau-mjau
Copy link

Did you manage to upgrade twig? I am missing several functionality from newer TWIG

@itskingori
Copy link
Contributor Author

@suncat100 Yes I was and have been using it on my site without any hiccups. Have a look at my fork which has the changes (I did send a pull request hence this thread). The commits are listed above.

This was in response to an issue filed (#77) but I guess @kolber hasn't had the chance to have a look at it yet.

The only thing that I'd caution you against is a bunch of lines I commented out because they caused a "Attribute callable does not exist for Node" error ... I can't explain why this gets rid of the error since I don't have the context of Stacey's inner workings.

Please note that I submitted this about 3 months ago and haven't updated my fork with the upstream and I can see he has submitted more commits since then.

@mjau-mjau
Copy link

@itsmrwave nice1 I will look into it ...

@o-l-e o-l-e mentioned this pull request Sep 18, 2013
Closed
@mjau-mjau mjau-mjau mentioned this pull request Dec 9, 2013
Closed
@MacilPrime MacilPrime mentioned this pull request May 27, 2014
Closed
@o-l-e
Copy link

o-l-e commented Dec 12, 2014

Hey @kolber hope you are all good!

Would it be possible to merge this pull, if it looks ok?
We are a gang trying to get the Stacey snippets page going, and some of the snippets require some of the filters in a later version of Twig :)

Sorry for nagging at you.

Discussion going on here: #97
Snippets (join in people) here: https://github.com/kolber/Stacey-Snippets

o-l-e pushed a commit to o-l-e/stacey that referenced this pull request Feb 19, 2015
upgraded to newer Twig to use |filters etc
6065c06 
- From this pull kolber#91
+ Specified variables for search in app/cache.inc.php on line 71/72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itskingori @mjau-mjau @o-l-e