Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reload and Hot Reload operators #16

Merged
merged 24 commits into from
Jan 13, 2025
Merged

Add Reload and Hot Reload operators #16

merged 24 commits into from
Jan 13, 2025

Conversation

BradyAJohnston
Copy link
Collaborator

@BradyAJohnston BradyAJohnston commented Jan 12, 2025

Adds a couple of properties for objects under the object.csv property group. Stores the filename on the object, which can then be used in the reloading of data from disk. Users could change data in a spreadsheet, save the data, and that will then be reflected in Blender upon reload.

  • Add tests

Currently the menu is displaying in the Object menu, but it should maybe go into the Object Data menu instead.

CleanShot.2025-01-12.at.19.52.11.mp4

Copy link
Owner

@kolibril13 kolibril13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! and it works as expected.

Screen.Recording.2025-01-12.at.14.41.12.mov

Should I merge?

@BradyAJohnston
Copy link
Collaborator Author

I'll add some tests first that cover the reloading then I'll merge.

@BradyAJohnston
Copy link
Collaborator Author

I wasn't able to get a test working for the 'Hot Reload', I think the timer likely isn't triggering properly when accessing via the API. It's intended only for a GUI interface anyway so I suppose we leave it for now.

@BradyAJohnston BradyAJohnston merged commit 68b5ce3 into main Jan 13, 2025
12 checks passed
@BradyAJohnston BradyAJohnston deleted the ops-reload branch January 13, 2025 07:33
@kolibril13
Copy link
Owner

Thanks for this great contribution!

I think the timer likely isn't triggering properly when accessing via the API
thanks for trying, I also think we can just leave it like this :)

I'll write a changelog and then release version 0.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants