Speed up launcher startup and collect more data about slow parts of startup #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
previously approved these changes
Jan 24, 2025
RebeccaMahany
force-pushed
the
becca/faster-launcher-startup
branch
from
16a35a8 to
5d448a3
Compare
James-Pickett
approved these changes
Jan 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DetectAndRemediateHardwareChangecan be extremely slow. Since we aren't actually remediating right now, we can move this call to a goroutine instead of blocking on it.MakeStorescan take as long as 45 seconds -- added some child spans to see if we can glean any more information about what's slow there.CheckExecutablecan be slow. (See: Speed up tuf.CheckExecutable #1585.) I see a couple example traces where it's taking nearly a minute, though, which should never happen -- the exec should time out after 5 seconds and we should attempt the exec no more than 3 times. So, I added a couple more spans to collect more information.