refactor: gcd function

kolotov · Sep 4, 2023 · 541dcbb · 541dcbb
1 parent 4a326bf
commit 541dcbb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/composer.json b/composer.json
@@ -20,8 +20,7 @@
     }
   ],
   "require": {
-    "wp-cli/php-cli-tools": "^0.11.19",
-    "ext-gmp": "*"
+    "wp-cli/php-cli-tools": "^0.11.19"
   },
   "bin": [
     "bin/brain-games",

diff --git a/src/Games/GcdGame.php b/src/Games/GcdGame.php
@@ -10,11 +10,14 @@
 return function ($module) {
     $module[LOCATION_SETTINGS][SETTING_RULES] = 'Find the greatest common divisor of given numbers.';
 
-    $module[LOCATION_HANDLERS][HANDLER_QUESTION] = function () {
+    $gcd = function ($a, $b) use (&$gcd) {
+        return $b === 0 ? $a : $gcd($b, $a % $b);
+    };
+
+    $module[LOCATION_HANDLERS][HANDLER_QUESTION] = function () use ($gcd) {
         $firstNum = random_int(1, 100);
         $secondNum = random_int(1, 100);
-
-        $expectedAnswer = gmp_gcd($firstNum, $firstNum);
+        $expectedAnswer = $gcd($firstNum, $firstNum);
         $question = "$firstNum $secondNum";
         return [$question, $expectedAnswer];
     };