feat: add orchestrator logic to the gem #128
Draft
+197
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| project_root = File.expand_path(File.join(__dir__, '..', '..', '..', '..', 'bas_use_cases', 'src', 'use_cases_execution')) | ||
| script_path = File.expand_path(File.join(project_root, script[:path].sub(%r{^src/use_cases_execution/}, ''))) | ||
| puts "Executing #{script_path} at #{current_time}" | ||
| if system("ruby #{script_path}") |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 8 hours ago
To fix the problem, we should avoid directly interpolating the script_path into the system command. Instead, we can pass the script_path as a separate argument to the system command, which will prevent the shell from interpreting any special characters in the path.
- Modify the
executemethod in theManagerclass to use the safer method of passing arguments to thesystemcommand. - Specifically, change the
system("ruby #{script_path}")line tosystem("ruby", script_path).
Suggested changeset
1
lib/bas/orchestrator/manager.rb
| @@ -38,3 +38,3 @@ | ||
|
|
||
| if system("ruby #{script_path}") | ||
| if system("ruby", script_path) | ||
| @last_executions[script[:path]] = time_in_milliseconds |
Copilot is powered by AI and may make mistakes. Always verify output.
AlanAlvarez21
force-pushed
the
orchestrator-cleanup
branch
from
b8a6cf6 to
118c8ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added orchestrator logic to manage and execute scheduled scripts based on time intervals, specific times, and days. Includes a manager class to handle the execution flow and corresponding tests.