Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize single release getting #373

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Optimize single release getting #373

merged 4 commits into from
Jun 23, 2023

Conversation

undera
Copy link
Collaborator

@undera undera commented Jun 23, 2023

Changes Proposed

Used dedicated Helm call to get individual release, instead of scanning full list always.

Check List

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 43.75% and project coverage change: +0.27 🎉

Comparison is base (27eb794) 29.82% compared to head (e0dad24) 30.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   29.82%   30.09%   +0.27%     
==========================================
  Files          10       10              
  Lines        1321     1329       +8     
==========================================
+ Hits          394      400       +6     
- Misses        888      890       +2     
  Partials       39       39              
Impacted Files Coverage Δ
pkg/dashboard/objects/releases.go 8.19% <43.75%> (+1.87%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@undera undera merged commit 4e2d318 into main Jun 23, 2023
4 checks passed
@undera undera deleted the optimize-release-getting branch June 23, 2023 09:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants