Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to disable query to ArtifactHub via env #515

Merged

Conversation

alessandrodetta
Copy link
Contributor

@alessandrodetta alessandrodetta commented Feb 23, 2024

It is now possible to disable the query through environment variable HD_NO_ARTIFACT_HUB_QUERY.

Changes Proposed

As suggested by @undera in #506

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue: Closes trying to check artifacts on ArtifactHub #506
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

It is now possible to disable the query through environment variable HD_NO_ARTIFACT_HUB_QUERY
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.18%. Comparing base (b5bed10) to head (4b93040).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   30.18%   30.18%           
=======================================
  Files          10       10           
  Lines        1335     1335           
=======================================
  Hits          403      403           
  Misses        891      891           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undera
Copy link
Collaborator

undera commented Feb 23, 2024

Very good.
Unfortunately, we have no documentation place to reflect this flag

@undera undera merged commit 274f1cd into komodorio:main Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trying to check artifacts on ArtifactHub
3 participants