Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added husky in the project #535

Closed
wants to merge 3 commits into from
Closed

Conversation

Ameerjafar
Copy link

@Ameerjafar Ameerjafar commented Jun 11, 2024

Changes Proposed

i have added the husky for the project with the help of this we don't worry to formatting the code.
I just created the package.json file in the root folder because we need to add the .husky folder and dependencies and then i have created the .husky folder inside the we have pre commit git hook file with the help of that we can able to format our code before the contributor make the commit.

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

@Ameerjafar
Copy link
Author

@undera can you kindly review this pr sir.

@@ -0,0 +1,25 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All frontend-related stuff is contained under /frontend directory. You should incorporate your proposed changes there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I want to install husky in our project we should initialize the .husky folder where the .github folder is contained(root folder) at the same time we need to install dependencies that is the reason I have created the package.json file in the root folder sir @undera

@undera
Copy link
Collaborator

undera commented Jun 11, 2024

I still don't understand why this needs to be part of the project. The change does not enforce anything on CI. If it's just local convenience helper - then it should remain for dev's won consideration.
We already have lint step for JS part in our CI. So I'm questioning if this PR adds any value, sorry.

@Ameerjafar
Copy link
Author

Ameerjafar commented Jun 12, 2024

I still don't understand why this needs to be part of the project. The change does not enforce anything on CI. If it's just local convenience helper - then it should remain for dev's won consideration. We already have lint step for JS part in our CI. So I'm questioning if this PR adds any value, sorry.

yes sir husky will create some value for our project because if you have some constraints in the commit message we can use commit-msg hook, inside this file we can give the constraints if the contributor commit msg did not pass this constraints the git won't allow to make the commit and it gives so much more functionality for us. @undera

@Ameerjafar Ameerjafar requested a review from undera June 12, 2024 03:42
@undera
Copy link
Collaborator

undera commented Jun 13, 2024

I'm sorry, but I still don't understand which problem does this solve. Can you explain the problem it solves?
From your explanation, it sets some restriction on commit messages. The project does not have any problem with that, due to PR process by GitHub.

@undera undera closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants