-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added husky in the project #535
Conversation
@undera can you kindly review this pr sir. |
@@ -0,0 +1,25 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All frontend-related stuff is contained under /frontend
directory. You should incorporate your proposed changes there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I want to install husky in our project we should initialize the .husky folder where the .github folder is contained(root folder) at the same time we need to install dependencies that is the reason I have created the package.json file in the root folder sir @undera
I still don't understand why this needs to be part of the project. The change does not enforce anything on CI. If it's just local convenience helper - then it should remain for dev's won consideration. |
yes sir husky will create some value for our project because if you have some constraints in the commit message we can use commit-msg hook, inside this file we can give the constraints if the contributor commit msg did not pass this constraints the git won't allow to make the commit and it gives so much more functionality for us. @undera |
I'm sorry, but I still don't understand which problem does this solve. Can you explain the problem it solves? |
Changes Proposed
i have added the husky for the project with the help of this we don't worry to formatting the code.
I just created the package.json file in the root folder because we need to add the .husky folder and dependencies and then i have created the .husky folder inside the we have pre commit git hook file with the help of that we can able to format our code before the contributor make the commit.
Check List