[KONFLUX-179]: ADR for provisioning clusters #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This ADR replaces #168. |
amisstea
requested review from
stuartwdouglas,
ralphbean,
ifireball,
dperaza4dustbit,
Dannyb48,
gbenhaim and
dirgim
|
@dperaza4dustbit, @gbenhaim I'd love to see your review comments to this proposal. |
ifireball
requested changes
Apr 8, 2024
This dictates how clusters will be provisioned from within an integration pipeline using the Cluster as a Service Operator. Signed-off-by: Alex Misstear <[email protected]>
Signed-off-by: Alex Misstear <[email protected]>
amisstea
force-pushed
the
KONFLUX-179-caas
branch
from
c847866
to
a6f563b
Compare
Signed-off-by: Alex Misstear <[email protected]>
amisstea
force-pushed
the
KONFLUX-179-caas
branch
from
a6f563b
to
9a571c7
Compare
Superfluous OIDC config details are also removed. Signed-off-by: Alex Misstear <[email protected]>
|
@arewm could you please give this another review pass? |
ifireball
approved these changes
May 21, 2024
arewm
approved these changes
Jun 5, 2024
Remove some uneccesary parenthesis as well. Signed-off-by: Alex Misstear <[email protected]>
dperaza4dustbit
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dictates how clusters will be provisioned from within an integration pipeline using the Cluster as a Service Operator.