Validate added migration file

STONEBLD-2827

Signed-off-by: Chenxiong Qi <[email protected]>

.github/workflows/check-task-migration.yaml

@@ -0,0 +1,28 @@
+name: Check task migrations
+"on":
+  pull_request:
+    branches: [main]
+jobs:
+  check:
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Create k8s Kind Cluster
+        uses: helm/[email protected]
+        with:
+          cluster_name: kind
+      - uses: tektoncd/actions/setup-tektoncd@main
+        with:
+          pipeline_version: latest
+      - name: Run check
+        run: |
+          kubectl get all -n tekton-pipelines
+          # Require name main
+          git branch main origin/main
+          # Make `git branch --show-current` works.
+          git checkout -b pr-verify
+          export IN_CLUSTER=1
+          bash -x ./hack/validate-migration.sh

hack/validate-migration.sh

@@ -0,0 +1,331 @@
+#!/usr/bin/env bash
+
+# Validate migration file introduced by a branch.
+#
+# This script can be run in the CI against a PR or in local from a topic branch.
+# Before run, all local changes have to be committed.
+#
+# Network is required to execute this script.
+#
+# Checks are implemented as functions whose name has prefix `check_`. Each of
+# them exits with status code 0 to indicate pass, otherwise exits
+# script execution immediately with non-zero code.
+#
+# Test with a local cluster:
+#
+# - Before starting test with local cluster, launch one by `kind create
+#   cluster'.  Then, install tekton pipelines
+#   https://tekton.dev/docs/pipelines/install/#installation
+#
+# - Set IN_CLUSTER to true.
+
+set -euo pipefail
+
+SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
+cd "$SCRIPTDIR/.." || exit 1
+unset SCRIPTDIR
+
+declare -r BUILD_PIPELINE_CONFIG=https://raw.githubusercontent.com/redhat-appstudio/infra-deployments/refs/heads/main/components/build-service/base/build-pipeline-config/build-pipeline-config.yaml
+
+WORK_DIR=$(mktemp -d --suffix=-validate-migrations)
+declare -r WORK_DIR
+
+: "${DEFAULT_BRANCH:=main}"
+declare -r DEFAULT_BRANCH
+
+# By default, do not run with a real kubernetes cluster.
+: "${IN_CLUSTER:=""}"
+declare -r IN_CLUSTER
+
+# 
+prepare_pipelines() {
+    local -a pl_names_in_config
+    local pushed_pipelines
+
+    mkdir -p "${WORK_DIR}/pipelines/pushed"
+
+    # Download pushed pipeline bundles from ConfigMap
+    pushed_pipelines=$(
+        curl --fail -sL "$BUILD_PIPELINE_CONFIG" | yq '.data."config.yaml"' | yq '.pipelines[] | .name + " " + .bundle'
+    )
+
+    while read -r pl_name pl_bundle; do
+        pl_names_in_config+=("$pl_name")
+        tkn bundle list "$pl_bundle" pipeline "$pl_name" -o yaml \
+            >"${WORK_DIR}/pipelines/pushed/${pl_name}.yaml"
+    done <<<"$pushed_pipelines"
+
+    mkdir -p "${WORK_DIR}/pipelines/local"
+    kubectl kustomize --output "${WORK_DIR}/pipelines/local" pipelines/
+
+    local -r names="${pl_names_in_config[*]}"
+    read -r hexdigits _ < <(sha256sum "${BASH_SOURCE[0]}")
+    local -r fake_digest="sha256:${hexdigits}"
+    local fake_bundle_ref=
+    local task_name=
+    local task_selector=
+
+    find "${WORK_DIR}/pipelines/local" -type f -name "*.yaml" | \
+        while read -r file_path; do
+            if [[ ! "$names" =~ $(yq '.metadata.name' "$file_path") ]]; then
+                # Drop pipelines that are not included in the config above.
+                rm "$file_path"
+            else
+                # Replace taskRef with fake bundle reference so that the
+                # .taskRef.version field will not confuse tekton.
+                #
+                for task_name in $(yq '(.spec.tasks[], .spec.finally[]) | .name' "$file_path"); do
+                    fake_bundle_ref="{
+                        \"resolver\": \"bundles\",
+                        \"params\": [
+                            {\"name\": \"name\", \"value\": \"${task_name}\"},
+                            {\"name\": \"bundle\", \"value\": \"${fake_digest}\"},
+                            {\"name\": \"kind\", \"value\": \"task\"}
+                        ]
+                    }"
+                    task_selector="((.spec.tasks[], .spec.finally[]) | select(.name == \"${task_name}\")"
+                    yq -i "${task_selector} | .taskRef) |= ${fake_bundle_ref}" "$file_path"
+                done
+            fi
+        done
+
+    return 0
+}
+
+list_preprocessed_pipelines() {
+    find "${WORK_DIR}/pipelines" -type f -name "*.yaml"
+}
+
+# Migration script should run without errors (0 exit code) on the pre-latest default pipeline.
+# after performing migration, the pipeline yaml should be valid (yaml and pipeline definition)
+# Test should run on all pipelines (docker, FBC and their trusted artifacts and remote versions)
+check_apply_on_pipelines() {
+    local -r migration_file=$1
+    local -r run_log_file=$(mktemp --suffix=-migration-run-test)
+    local -r prepared_pipelines=$(list_preprocessed_pipelines)
+    local failed=
+    local file_path=
+    local updated=
+    while read -r file_path; do
+        cp "$file_path" "${file_path}.copy"
+        if ! bash -x "$migration_file" "${file_path}.copy" 2>"$run_log_file" >&2; then
+            echo "error: failed to run migration file $migration_file on pipeline $file_path:" >&2
+            cat "$run_log_file" >&2
+            failed=true
+        else
+            if ! diff "$file_path" "${file_path}.copy" >/dev/null 2>&1; then
+                updated=true
+                mv "${file_path}.copy" "${file_path}.modified"
+            fi
+        fi
+    done <<<"$prepared_pipelines"
+    rm "$run_log_file"
+    if [ -z "$updated" ]; then
+        mapfile -t pl_names < <(
+            while read -r file_path; do
+                yq ".metadata.name" "$file_path"
+            done <<<"$prepared_pipelines" \
+                | sort | uniq
+        )
+        echo "${FUNCNAME[0]}: migration file does not modify any of pipelines ${pl_names[*]}" >&2
+    fi
+    if [ -n "$failed" ] || [ -z "$updated" ]; then
+        return 1
+    else
+        return 0
+    fi
+}
+
+# Run shellcheck against the given migration file without rules customization.
+# Developers could write inline shellcheck rules.
+check_pass_shellcheck() {
+    local -r migration_file=$1
+    if shellcheck -e SC2148 "$migration_file"; then
+        return 0
+    fi
+    return 1
+}
+
+# Determine if a task is a normal task. 0 returns if it is, otherwise 1 is returned.
+is_normal_task() {
+    local -r task_dir=$1
+    local -r task_name=$2
+    if [ -f "${task_dir}/${task_name}.yaml" ]; then
+        return 0
+    fi
+    return 1
+}
+
+# Determine if a task is a kustomized task. 0 returns if it is, otherwise 1 is returned.
+is_kustomized_task() {
+    local -r task_dir=$1
+    local -r task_name=$2
+    local -r kt_config_file="$task_dir/kustomization.yaml"
+    local -r task_file="${task_dir}/${task_name}.yaml"
+    if [ -f "$kt_config_file" ] && [ ! -e "$task_file" ]; then
+        return 0
+    fi
+    return 1
+}
+
+# Resolve the parent directory of given migration. For example, the given
+# migration file is path/to/dir/migrations/0.1.1.sh, then function outputs
+# path/to/dir. The parent directory path is output to stdout.
+# Arguments: migration file path.
+resolve_migrations_parent_dir() {
+    local -r migration_file=$1
+    local -r dir_path=${migration_file%/*}  # remove file name
+    echo "${dir_path%/*}"  # remove path component migrations/
+}
+
+check_migrations_is_in_task_version_specific_dir() {
+    local -r migration_file=$1
+    local -r parent_dir=$(resolve_migrations_parent_dir "$migration_file")
+    local -r result=$(find task/*/* -type d -regex "$parent_dir" -print -quit)
+    if [ -z "$result" ]; then
+        echo "${FUNCNAME[0]}: migrations/ directory is not created in a task version-specific directory. Current is under $parent_dir. To fix it, move it to a path like task/task-1/0.1/." >&2
+        exit 1
+    fi
+}
+
+# Check that version within the migration file name must match the task version
+# in task label .metadata.labels."app.kubernetes.io/version".
+check_version_match() {
+    local -r migration_file=$1
+    local -r task_dir=$(resolve_migrations_parent_dir "$migration_file")
+
+    local task_name=${task_dir%/*}  # remove version part
+    task_name=${task_name##*/}  # remove all path components before the name
+
+    local task_version=
+    local -r label='.metadata.labels."app.kubernetes.io/version"'
+
+    if is_normal_task "$task_dir" "$task_name" ; then
+        task_version=$(yq "$label" "${task_dir}/${task_name}.yaml")
+    elif is_kustomized_task "$task_dir" "$task_name"; then
+        task_version=$(kubectl kustomize "$task_dir" | yq "$label")
+    else
+        exit 1
+    fi
+
+    if [ "${migration_file%/*}/${task_version}.sh" == "$migration_file" ]; then
+        return 0
+    fi
+
+    echo -n "${FUNCNAME[0]}: migration file does not match the task version '${task_version}'. " >&2
+    echo "Bump version in label 'app.kubernetes.io/version' to match the migration." >&2
+
+    return 1
+}
+
+is_on_topic_branch() {
+    if [ "$(git branch --show-current)" != "$DEFAULT_BRANCH" ]; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+is_migration_file() {
+    local -r file_path=$1
+    if [[ "$file_path" =~ /migrations/[0-9.]+\.sh$ ]]; then
+        return 0
+    fi
+    return 1
+}
+
+# Output migration file included in the branch
+# The file name is output to stdout with relative path to the root of the repository.
+# Generally, there should be one, but if multiple migration files are
+# discovered, it will be checked later. # No argument is required. Function
+# inspects changed files from current branch directly.
+list_migration_files() {
+    git diff --name-status "$(git merge-base HEAD $DEFAULT_BRANCH)" | \
+        while read -r status origin_path; do
+            if ! is_migration_file "$origin_path"; then
+                continue
+            fi
+            case "$status" in
+                A)  # file is added
+                    echo "$origin_path"
+                    ;;
+                D | M)
+                    echo "It is not allowed to delete or modify existing migration file: $origin_path" >&2
+                    exit 1
+                    ;;
+                *)
+                    echo "warning: unknown operation for status $status on file $origin_path" >&2
+                    ;;
+            esac
+        done
+    return $?
+}
+
+K8S_TEST_NS=validate-migration-test
+declare -r K8S_TEST_NS
+
+# Check whether modified pipelines with applied migration is broken or not.
+# This check requires a created cluster with tekton installed.
+# An easy way to set up a local cluster is running `kind create cluster'.
+check_apply_in_real_cluster() {
+    if [ -z "$IN_CLUSTER" ]; then
+        return 0
+    fi
+    if ! kubectl get crd pipelines.tekton.dev -n tekton-pipelines >/dev/null 2>&1; then
+        echo "error: cannot find CRD pipeline.tekton.dev from cluster. Please create a cluster and install tekton." >&2
+        exit 1
+    fi
+    if kubectl get namespaces ${K8S_TEST_NS} >/dev/null 2>&1; then
+        kubectl delete pipeline --all -n ${K8S_TEST_NS} >/dev/null
+    else
+        kubectl create namespace ${K8S_TEST_NS}
+    fi
+    local -r apply_logfile=$(mktemp --suffix="-${FUNCNAME[0]}")
+    local -r modified_pipeline_files=$(find "${WORK_DIR}/pipelines" -type f -name "*.modified")
+    while read -r pl_file; do
+        if ! kubectl apply -f "$pl_file" -n ${K8S_TEST_NS} 2>"$apply_logfile" >/dev/null; then
+            echo "${FUNCNAME[0]}: failed to apply pipeline to cluster: $pl_file" >&2
+            cat "$apply_logfile" >&2
+            rm "$apply_logfile"
+            exit 1
+        fi
+    done <<<"${modified_pipeline_files}"
+    rm "$apply_logfile"
+}
+
+main() {
+    if git status --porcelain | grep -qv "^??"; then
+        echo "There are uncommitted changes. Please commit them and run again." >&2
+        exit 1
+    fi
+
+    if ! is_on_topic_branch; then
+        echo "Script must run on a topic branch rather than the main branch." >&2
+        return 1
+    fi
+
+    local -a migrations_files
+    mapfile -t migrations_files < <(list_migration_files)
+
+    if [[ ${#migrations_files[@]} -eq 0 ]]; then
+        echo "No migration."
+        exit 0
+    fi
+
+    local -r n=${#migrations_files[@]}
+    if [[ $n -gt 1 ]]; then
+        echo "error: found $n migration files. Please ensure to include a single migration file per time." >&2
+        exit 1
+    fi
+
+    prepare_pipelines
+
+    local -r file_path=${migrations_files[0]}
+    check_pass_shellcheck "$file_path"
+    check_migrations_is_in_task_version_specific_dir "$file_path"
+    check_version_match "$file_path"
+    check_apply_on_pipelines "$file_path"
+    check_apply_in_real_cluster
+}
+
+main "$@"