-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend the sast-coverity-check CI task to support buildful scanning #1653
Open
kdudka
wants to merge
7
commits into
konflux-ci:main
Choose a base branch
from
kdudka:cov-bf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,546
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
force-pushed
the
cov-bf
branch
10 times, most recently
from
December 2, 2024 15:02
d9f50ab
to
d105ef6
Compare
5 tasks
kdudka
force-pushed
the
cov-bf
branch
4 times, most recently
from
December 12, 2024 09:54
01c1285
to
31c6f24
Compare
/ok-to-test |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
It was required but not used for anything. Also the parameters set in the build template were not used by the coverity-availability-check task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... which is not used for anything Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
It was required but not used for anything. Also the parameters set in the build template were not used by the coverity-availability-check task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... which is not used for anything Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 12, 2024
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
/ok-to-test |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Dec 17, 2024
/ok-to-test |
I have successfully tested the proposed changes on a few pull requests:
@konflux-ci/integration-service-maintainers @konflux-ci/build-maintainers Could you please proceed with the review? |
They cause the CI to be red on tasks derived from the buildah task. Related: konflux-ci#1653
It was required but not used for anything. Also the parameters set in the build template were not used by the coverity-availability-check task. Related: konflux-ci#1653
... which is not used for anything Related: konflux-ci#1653
... to make the interface compatible with the `build-container` task Related: konflux-ci#1653
... from the build-container task. The `hack/generate-sast-tasks.sh` script can be used to rebuild `sast-coverity-check.yaml`. Related: konflux-ci#1653
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://issues.redhat.com/browse/OSH-750