Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the command using the python script create_purl_sbom.py #1773

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cmoulliard
Copy link
Contributor

  • Remove the command using the python script create_purl_sbom.py as deprecated.
  • Remove also from the README the BUILDER_NAME as users cannot define it

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

…recated. Remove also from the README the BUILDER_NAME as users cannot define it

Signed-off-by: cmoulliard <[email protected]>
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task still seems to use the sbom-purl.json

buildah --storage-driver "$STORAGE_DRIVER" copy "$container" sbom-cyclonedx.json sbom-purl.json /root/buildinfo/content_manifests/

The buildah tasks don't inject any SBOMs into the image anymore, so I would imagine this one doesn't have to do it either

@cmoulliard
Copy link
Contributor Author

The buildah tasks don't inject any SBOMs into the image anymore, so I would imagine this one doesn't have to do it either

Fixed: 048ba8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants