-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vale linter to CI #201
Conversation
🚀 Preview is available at https://pr-201--konflux-docs.netlify.app |
🚀 Preview is available at https://pr-201--konflux-docs.netlify.app |
acf33ef
to
b5e33c0
Compare
🚀 Preview is available at https://pr-201--konflux-docs.netlify.app |
b5e33c0
to
7a81b18
Compare
This patch introduces Vale¹ as a writing style linter, and configures it using Red Hat's styles². It also sets up a corresponding Github Action to run Vale during the CI. If any of the lines introduced by the PR causes an error level linting message, the CI will fail. ¹https://vale.sh/docs ²https://redhat-documentation.github.io/vale-at-red-hat/docs/main/user-guide/introduction/ Signed-off-by: Bruno Pimentel <[email protected]>
7a81b18
to
23c0850
Compare
🚀 Preview is available at https://pr-201--konflux-docs.netlify.app |
1 similar comment
🚀 Preview is available at https://pr-201--konflux-docs.netlify.app |
@arewm @ralphbean thoughts on the direction here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't necessarily have any issue with this. Is there a sample of what the output might look like? Is it only run against the differential?
It is run only against the differential. I had a commit to force errors at some point, take a look the CI run for it here. |
Should we run the linter against the content as we have it today? |
If you look at the vale linter output here, you'll see that it does check the whole content, but it only triggers a CI failure for errors that belong to the diff. |
This patch introduces Vale as a writing style linter, and configures it using Red Hat's styles.
It also sets up a corresponding Github Action to run Vale during the CI. If any of the lines introduced by the PR causes an error level linting message, the CI will fail.