Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vale linter to CI #201

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add Vale linter to CI #201

merged 1 commit into from
Jan 14, 2025

Conversation

brunoapimentel
Copy link
Contributor

@brunoapimentel brunoapimentel commented Jan 7, 2025

This patch introduces Vale as a writing style linter, and configures it using Red Hat's styles.

It also sets up a corresponding Github Action to run Vale during the CI. If any of the lines introduced by the PR causes an error level linting message, the CI will fail.

Copy link

github-actions bot commented Jan 7, 2025

🚀 Preview is available at https://pr-201--konflux-docs.netlify.app

Copy link

🚀 Preview is available at https://pr-201--konflux-docs.netlify.app

Copy link

🚀 Preview is available at https://pr-201--konflux-docs.netlify.app

This patch introduces Vale¹ as a writing style linter, and configures it
using Red Hat's styles².

It also sets up a corresponding Github Action to run Vale during the CI.
If any of the lines introduced by the PR causes an error level linting
message, the CI will fail.

¹https://vale.sh/docs
²https://redhat-documentation.github.io/vale-at-red-hat/docs/main/user-guide/introduction/

Signed-off-by: Bruno Pimentel <[email protected]>
@brunoapimentel brunoapimentel marked this pull request as ready for review January 13, 2025 14:15
Copy link

🚀 Preview is available at https://pr-201--konflux-docs.netlify.app

1 similar comment
Copy link

🚀 Preview is available at https://pr-201--konflux-docs.netlify.app

@brunoapimentel
Copy link
Contributor Author

@arewm @ralphbean thoughts on the direction here?

Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't necessarily have any issue with this. Is there a sample of what the output might look like? Is it only run against the differential?

@brunoapimentel
Copy link
Contributor Author

I don't necessarily have any issue with this. Is there a sample of what the output might look like? Is it only run against the differential?

It is run only against the differential. I had a commit to force errors at some point, take a look the CI run for it here.

@arewm arewm merged commit 06f0ce5 into konflux-ci:main Jan 14, 2025
3 checks passed
@arewm
Copy link
Member

arewm commented Jan 14, 2025

Should we run the linter against the content as we have it today?

@brunoapimentel
Copy link
Contributor Author

Should we run the linter against the content as we have it today?

If you look at the vale linter output here, you'll see that it does check the whole content, but it only triggers a CI failure for errors that belong to the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants