chore(RHTAPWATCH-1094): Add predicates to controller#3
Merged
avi-biton merged 2 commits intokonflux-ci:mainfrom Jul 8, 2024
Merged
chore(RHTAPWATCH-1094): Add predicates to controller#3avi-biton merged 2 commits intokonflux-ci:mainfrom
avi-biton merged 2 commits intokonflux-ci:mainfrom
Conversation
gbenhaim
reviewed
Jul 2, 2024
gbenhaim
reviewed
Jul 2, 2024
gbenhaim
reviewed
Jul 2, 2024
gbenhaim
reviewed
Jul 2, 2024
gbenhaim
reviewed
Jul 2, 2024
Add predicates to the controller to handle: Created push pipeline Finished push pipeline with no notification annotation Finished push pipeline with finalizer Signed-off-by: Avi Biton <abiton@redhat.com>
When the roles were updated in the reconciler, a `make generate` command updated the role.yaml file Signed-off-by: Avi Biton <abiton@redhat.com>
Member
Author
|
@gbenhaim I think I covered all scenarios, PTAL |
gbenhaim
approved these changes
Jul 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add predicates to the controller to handle only created and successfully ended push pipelineruns
Updating parameters in
pipelinerun_helper.goto Object instead of pipelineRun so it will be possible to use them in predicate events.Fix some static checks warnings