Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RHTAPWATCH-1159): add pipelinerun name to message sent to SNS #6

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore(RHTAPWATCH-1159): add pipelinerun name to message sent to SNS #6

merged 1 commit into from
Jul 18, 2024

Conversation

avi-biton
Copy link
Collaborator

add the pipelinerun name to the results extracted
from the pipelinerun

yftacherzog
yftacherzog reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the names could be improved. Added some suggestions.
Also, how come this does not affect the tests we have?

internal/controller/pipelinerun_helper.go Outdated Show resolved Hide resolved
internal/controller/pipelinerun_helper.go Outdated Show resolved Hide resolved
@avi-biton
Copy link
Collaborator Author

how come this does not affect the tests we have?

Why should it?
The integration tests uses a mock to notify and we did not add unit tests to these functions

yftacherzog
yftacherzog approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we should create tickets for adding unit tests to this function and others that allow it.

@avi-biton
Copy link
Collaborator Author

lgtm. I think we should create tickets for adding unit tests to this function and others that allow it.

I am working on it :)

@avi-biton avi-biton requested a review from yftacherzog July 18, 2024 12:43
@avi-biton
Copy link
Collaborator Author

@yftacherzog PTAL again, I changed the function to return an error in case Results is empty (no results)

@avi-biton
chore(RHTAPWATCH-1159): add pipelinerun name to message sent to SNS
b4e770e 
add the pipelinerun name to the results extracted
from the pipelinerun

Signed-off-by: Avi Biton <[email protected]>
@avi-biton avi-biton merged commit d195f4d into konflux-ci:main Jul 18, 2024
2 checks passed
@avi-biton avi-biton deleted the adjust_message branch July 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yftacherzog yftacherzog yftacherzog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avi-biton @yftacherzog