add unit tests to pipelinerun_helper #8
Conversation
There was a problem hiding this comment.
How does it look when one function is failing?
I was expecting the unit tests to be separated by the units (functions) being tested.
I do see some sense now with grouping them by context, which can represent a single scenario in which the different functions are called. having said that, I'd like to see that when we have a regression in one function, the results will point to that function, rather than to a case with many functions.
It is well organized when using the |
ok. I'm good with that. In that case, I think the |
avi-biton
force-pushed
the
unit_tests
branch
2 times, most recently
from
5c0f4dc to
e2d7457
Compare
| result := []tektonv1.PipelineRunResult{ | ||
| { | ||
| Name: "PIPELINERUN_NAME", | ||
| Value: *tektonv1.NewStructuredValues(testTruePipelineRun.Name), | ||
| }, | ||
| { | ||
| Name: "IMAGE_DIGEST", | ||
| Value: *tektonv1.NewStructuredValues("image_digest_value"), | ||
| }, | ||
| { | ||
| Name: "IMAGE_URL", | ||
| Value: *tektonv1.NewStructuredValues("image"), | ||
| }, | ||
| { | ||
| Name: "CHAINS-GIT_URL", | ||
| Value: *tektonv1.NewStructuredValues("git_url_value"), | ||
| }, | ||
| { | ||
| Name: "CHAINS-GIT_COMMIT", | ||
| Value: *tektonv1.NewStructuredValues("git_commit_value"), | ||
| }, | ||
| } |
There was a problem hiding this comment.
Is the eventual comparison sensitive to the order of the results? If we see flakiness, we'll need to look into this again.
Add unit tests to pipelinerun helper Signed-off-by: Avi Biton <[email protected]>
Add unit tests to pipelinerun_helper