Skip to content

Commit

Permalink
fix: tweak github actions (#604)
Browse files Browse the repository at this point in the history
* chore: update checkout action to v4

Some places were already on version 4. Move the rest
as well.

v3 would print this warning:

The following actions use a deprecated Node.js version and
will be forced to run on node20: actions/checkout@v3.

Signed-off-by: Martin Malina <[email protected]>

* fix: tweak Promote branch inputs

When you trigger the workflow via Github UI, it will
not show you the name of those inputs. It just shows
checkboxes and the description next to them.

So let's add the input names to the descriptions
and also remove the "If set to true" part, as it doesn't
make sense in the UI.

Signed-off-by: Martin Malina <[email protected]>

---------

Signed-off-by: Martin Malina <[email protected]>
  • Loading branch information
mmalina authored Oct 9, 2024
1 parent 6ac439f commit 227ab87
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/promote_branch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ on:
- production
force-to-staging:
description: |
If passed with value true, allow promotion to staging even if staging and production differ
Force to staging: Allow promotion to staging even if staging and production differ
type: boolean
required: true
default: false
override:
description: |
If passed with value true, allow promotion to production even if the change has not been in staging for one
Override: Allow promotion to production even if the change has not been in staging for one
week
type: boolean
required: true
default: false
dry-run:
description: |
If passed with value true, print out the changes that would be promoted but do not perform the git push
Dry run: Print out the changes that would be promoted but do not perform the git push
type: boolean
required: true
default: false
Expand All @@ -36,7 +36,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Run branch promotion script
run: |
.github/scripts/promote_branch.sh --target-branch $TARGET --force-to-staging $FORCE \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tekton_task_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Get changed dirs
id: changed-dirs
uses: tj-actions/changed-files@v41
Expand Down

0 comments on commit 227ab87

Please sign in to comment.