Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitlint installation #588

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: gitlint installation #588

merged 1 commit into from
Oct 16, 2024

Conversation

mmalina
Copy link
Collaborator

@mmalina mmalina commented Oct 16, 2024

Latest ubuntu does not allow system wide pip install. It can be overriden with --break-system-packages, but it's better to create a virtual env.

This first came up here: hacbs-release/app-interface-deployments#198

Latest ubuntu does not allow system wide pip install.
It can be overriden with `--break-system-packages`,
but it's better to create a virtual env.

Signed-off-by: Martin Malina <[email protected]>
@mmalina mmalina requested a review from a team as a code owner October 16, 2024 12:31
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (fc70fe4) to head (aade749).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   84.09%   84.21%   +0.11%     
==========================================
  Files          26       26              
  Lines        1742     1742              
==========================================
+ Hits         1465     1467       +2     
+ Misses        192      191       -1     
+ Partials       85       84       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmalina mmalina merged commit 69ae839 into konflux-ci:main Oct 16, 2024
9 checks passed
@mmalina mmalina deleted the fix-gitlint branch October 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants