Skip to content
This repository has been archived by the owner on Oct 18, 2020. It is now read-only.

New CSS & SCSS, animations, clearer typography, nicer looking everything #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sammularczyk
Copy link

Quick rewrite of the CSS using Compass and SCSS. Had to alter the javascript in main.js to assist with styling. Feel free to change some stuff around if you think it'll work better

Better typography (with less cognitive load), and works great on mobile. Let me know what you think!

@konklone
Copy link
Owner

OK, my apologies for letting this sit so long -- I didn't get to very much SHAAAAA work at all this past week.

Thank you for taking the time to do this, @sammularczyk! This makes a lot of stuff better, and I'd like to incorporate much of it.

So we have it in thread to compare -- here's the current site:

shaaaa-old

And here's the proposed redesign:

redesign

Some things I like a lot about it:

  • More readable font
  • Way better search/button form, especially on mobile
  • Very nice face icon backgrounds for Yes/No/Almost
  • The "Why?" header
  • Overall clean feeling
  • Easter egg on mousing over title

Some things I don't:

  • shaaaaaaaaa title is now understated instead of the loud, overstated yelling I was going for
  • similarly, I prefer the large and loud Dang, Almost, etc. words
  • my crude warnings progression image lost its border, is revealed in all its crudity. I know CSS borders on images are kind of lame, but I don't think my image survives without it.
  • text is a little light for the background, same for links
  • the fade-in effect
  • the animation effects upon window resize (though this isn't a big deal, since who resizes browser windows anyway)

So @sammularczyk, what I'd like to do is take the parts I like, and leave the parts I don't. I'm happy to do that work myself, and credit you just as you are in this PR, if you don't object. You're also welcome to take a second pass based on this feedback. In either case, I may end up making more design tweaks and changes afterwards, though I'll happily cc you on any commits that affect design in any substantive way.

Again: thank you for taking this on pro bono! I think this takes the site in a good direction, and it's very motivating to me.

@sammularczyk
Copy link
Author

Sorry man!! This email didn't come through to my inbox. Happy to fix it up, but also feel free to change some stuff around

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants