Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An arc length computation test fails with insufficient precision on Travis-CI for Python 3.8 #76

Closed
konstantint opened this issue Jan 27, 2024 · 2 comments

Comments

@konstantint
Copy link
Owner

See https://app.travis-ci.com/github/konstantint/matplotlib-venn/jobs/616934442

@skupr-anaconda
Copy link

Is this issue caused by numpy 1.24 (?) and python 3.8? We got the same error only on linux-64, see AnacondaRecipes/matplotlib-venn-feedstock#2 (comment)

@konstantint
Copy link
Owner Author

I do not have a very good idea of what the real problem here was, but it does seem that different numpy versions on different python versions can produce different types of objects (e.g. sometimes a float, sometimes a np.float. Most confuslingly - sometimes a bool, sometimes a thing like np.True_). I unified some of the code to always return one type in c742161.

As Travis stopped my builds because of some pricing changes I don't really know whether it would still fail on Travis in some configuration, at least I cannot seem to reproduce any failures on any versions locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants