Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib-venn 0.11.10 #2

Merged
merged 10 commits into from
Jul 9, 2024
Merged

matplotlib-venn 0.11.10 #2

merged 10 commits into from
Jul 9, 2024

Conversation

psteyer
Copy link

@psteyer psteyer commented Jul 2, 2024

matplotlib-venn 0.11.10 ❄️

Destination channel: Snowflake

Links

Explanation of changes:

  • build for 0.11.10
  • changing source in order to include tests
  • removing test for py38. See thread for details

@psteyer psteyer self-assigned this Jul 2, 2024
@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_8bnzi12a4f/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:16: avoid_noarch: noarch: python packages should be avoided

===== ERRORS =====

  • clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps and --no-build-isolation.
    ===== Final Report: =====
    1 Error and 1 Warning were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_0a86m_949i/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:16: avoid_noarch: noarch: python packages should be avoided
    ===== Final Report: =====
    0 Errors and 1 Warning were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_4bncjl52hb/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

  • clone/recipe/meta.yaml:15: avoid_noarch: noarch: python packages should be avoided
    ===== Final Report: =====
    0 Errors and 1 Warning were found

Copy link

@lorepirri lorepirri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks for the tests!

Copy link

@ifitchet ifitchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "delete branch on merge" and "branch protection rules" :)

recipe/meta.yaml Outdated
Comment on lines 13 to 15
noarch: python
script: {{ PYTHON }} -m pip install . --no-deps -vv
script: {{ PYTHON }} -m pip install . --no-deps -vv --no-deps --no-build-isolation
skip: True # [py<36]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a noarch line and you have two --no-deps

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I've added suggestions

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Lorenzo Pirritano <[email protected]>
@psteyer
Copy link
Author

psteyer commented Jul 3, 2024

I'm unsure why all the sudden linux-64 is having a test failure. It's specifically for python 3.8 I believe. FAILED tests/region_test.py::test_circle_region.

I'm not sure I understand the reason for the Assertion Error. In this case should I just go ahead and skip test_circle_region?

@skupr-anaconda
Copy link

skupr-anaconda commented Jul 4, 2024

I'm unsure why all the sudden linux-64 is having a test failure. It's specifically for python 3.8 I believe. FAILED tests/region_test.py::test_circle_region.

I'm not sure I understand the reason for the Assertion Error. In this case should I just go ahead and skip test_circle_region?

@psteyer Yes, you can skip test_circle_region for py38 because it requires sufficient precision on CI systems, see the upstream issue konstantint/matplotlib-venn#76 and the maintainers also skip testing it https://github.com/konstantint/matplotlib-venn/blob/0.11.10/.travis.yml#L7-L8.
It can be an issue caused by numpy 1.24.3 (?) and python 3.8 on linux-64.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@psteyer psteyer merged commit a027a27 into main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants