feat : custom repositories #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can I test this? Also, there's some formatting errors in the code - can be fixed by running |
|
You can run console,api locally and checkout my branch |
jokestax
force-pushed
the
feat-custom-repo
branch
from
30c8894
to
6aa78d8
Compare
|
Is there a reason why this is only for Civo? These kind of features should be implemented on all clouds to prevent difference in features between them. It's not a great experience for users on other cloud if they can't have the same features, it's more annoying to document, and a pain to maintain after :) |
|
Now it's on all clouds Fred, sorry for not updating it |
|
@jokestax great, I didn't check the code yet, just check the PR title :) |
jokestax
force-pushed
the
feat-custom-repo
branch
from
92221ba
to
5076abd
Compare
jokestax
force-pushed
the
feat-custom-repo
branch
from
5076abd
to
b547785
Compare
Co-authored-by: Patrick D'appollonio <[email protected]>
This reverts commit 0173e0782480c854202e58a075b3ea063bf8c331.
… 0.102.0 skip-checks:true
… 0.103.0 skip-checks:true
… 0.104.0 skip-checks:true
… 0.105.0 skip-checks:true
* fix: secret gitops catalog * added fix for import cluster * format type * format-type-typo * revert
* fix: import * Update internal/secrets/import.go Co-authored-by: Patrick D'appollonio <[email protected]> * fix: return --------- Co-authored-by: Patrick D'appollonio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can now deploy multiple repos on same organistation using below flags :
"--gitopsRepoName" metaphorRepoName "adminTeamName" "developerTeamName"
but we have to use kubefirst repo branch "feat-custom-repo" and kubefirst-gitops-template repo branch "feat-custom-repo" until its merged into main