Add property tests for invariants #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@konsumlamm what do you think? Are these bugs? |
|
Yes, I'm pretty sure, though I didn't have enough time to investigate them yet. The failures for |
This was referenced Dec 25, 2023
|
Those issues should now be fixed. Could you rebase, so that the CI runs again? |
|
Nice, thanks for fixing! |
konsumlamm
reviewed
Jan 1, 2024
|
Great work, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These invariants are based on my understanding of RRB-trees. There seem to be a few variations of RRB-trees from what I could find online, so correct me if any of these do not apply to this implementation. Also, let me know if I missed some invariant that could be tested.
The added tests detect that:
<|can create anUnbalancedwithm+1children><can create a rootUnbalancedwith 1 childinsertAtcan create a rootUnbalancedwith 1 childdeleteAtcan create a rootUnbalancedwith 1 childSide note: I found that shrinking sometimes seems to be taking forever but I haven't attempted to address it in this PR.
Fixes #16