🐛 remove dep label selector from dependency condition (#380)

fixes #377 Signed-off-by: Shawn Hurley <[email protected]>
konveyor · Oct 19, 2023 · 6b0dfac · 6b0dfac
1 parent 20a9d91
commit 6b0dfac
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/parser/rule_parser.go b/parser/rule_parser.go
@@ -724,8 +724,7 @@ func (r *RuleParser) getConditionForProvider(langProvider, capability string, va
 
 	if capability == "dependency" && !r.NoDependencyRules {
 		depCondition := provider.DependencyCondition{
-			Client:        client,
-			LabelSelector: r.DepLabelSelector,
+			Client: client,
 		}
 
 		fullCondition, ok := value.(map[interface{}]interface{})

diff --git a/provider/provider.go b/provider/provider.go
@@ -525,8 +525,6 @@ type DependencyCondition struct {
 	NameRegex string
 
 	Client Client
-
-	LabelSelector *labels.LabelSelector[*Dep]
 }
 
 func (dc DependencyCondition) Evaluate(ctx context.Context, log logr.Logger, condCtx engine.ConditionContext) (engine.ConditionResponse, error) {
@@ -549,16 +547,6 @@ func (dc DependencyCondition) Evaluate(ctx context.Context, log logr.Logger, con
 	matchedDeps := []matchedDep{}
 	for u, ds := range deps {
 		for _, dep := range ds {
-			if dc.LabelSelector != nil {
-				got, err := dc.LabelSelector.Matches(dep)
-				if err != nil {
-					return resp, err
-				}
-				if !got {
-					continue
-				}
-			}
-
 			if dep.Name == dc.Name {
 				matchedDeps = append(matchedDeps, matchedDep{dep: dep, uri: u})
 				break