Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prevent gradle logic from decompressing jars all the time #663

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Jul 17, 2024

The gradle analysis was uncompressing jars every time because of a lack of a check for the existence of the already decompressed directory.

cmd.Dir = filepath.Dir(sourcesFile)
err = cmd.Run()
if err != nil {
fmt.Printf("\n java error%v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we should hard-fail here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally let the analysis continue, since it's only one JAR that failed decompressing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Gradle analysis taking too long to complete
3 participants