🐛 Fix transaction deadlock in dep builder. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
shawn-hurley
approved these changes
Aug 6, 2024
dymurray
added
the
cherry-pick/release-0.5
dymurray
approved these changes
Aug 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
closes #121 The `addon.Activity()` reports addon activity which is appended to the TaskReport.Activity using a PUT. This will briefly acquire a DB transaction (in the hub). The builder MUST not report activity because the addon already has a transaction open in the hub because of the POST of the analysis report. This creates a DEADLOCK. **There is a race-condition**: This only happens when the hub begins the transaction before the dep writer reports the dep.yaml not found. I can force this by adding a sleep to where the writer reports this. I suspect the hub can be busy enough with UI GET requests to delay it beginning the analysis POST until after the builder reports the file not found. Flow: ``` addon hub | post analysis ----- >| | | begin tx | writer <-------------| read | writer: put task --> | begin tx (deadlock) ``` Regression added PR #97 Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
dymurray
pushed a commit
that referenced
this pull request
Aug 6, 2024
closes #121 The `addon.Activity()` reports addon activity which is appended to the TaskReport.Activity using a PUT. This will briefly acquire a DB transaction (in the hub). The builder MUST not report activity because the addon already has a transaction open in the hub because of the POST of the analysis report. This creates a DEADLOCK. **There is a race-condition**: This only happens when the hub begins the transaction before the dep writer reports the dep.yaml not found. I can force this by adding a sleep to where the writer reports this. I suspect the hub can be busy enough with UI GET requests to delay it beginning the analysis POST until after the builder reports the file not found. Flow: ``` addon hub | post analysis ----- >| | | begin tx | writer <-------------| read | writer: put task --> | begin tx (deadlock) ``` Regression added PR #97 Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #121
The
addon.Activity()reports addon activity which is appended to the TaskReport.Activity using a PUT. This will briefly acquire a DB transaction (in the hub).The builder MUST not report activity because the addon already has a transaction open in the hub because of the POST of the analysis report. This creates a DEADLOCK.
There is a race-condition: This only happens when the hub begins the transaction before the dep writer reports the dep.yaml not found. I can force this by adding a sleep to where the writer reports this. I suspect the hub can be busy enough with UI GET requests to delay it beginning the analysis POST until after the builder reports the file not found.
Flow:
Regression added PR #97