Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for modes and bimary analysis. #19

Merged
merged 16 commits into from
Jul 7, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jun 28, 2023

Add support for modes:

  • binary
    • with uploaded binary
    • with maven coordinates.
  • source
  • source+deps

Support RuleSet dependencies.
Set maven settings.xml for credentials.

Structured error reporting. Includes reporting analyzer rule errors.

Disabled reporting application facts for now. The Extras are not facts.

closes #18

@jortel jortel marked this pull request as ready for review June 29, 2023 13:21
@jortel jortel changed the title Add support for modes and bimary analysis. ✨ Add support for modes and bimary analysis. Jun 29, 2023
@jortel jortel requested a review from mansam July 6, 2023 22:42
builder/issue.go Outdated
}

func (e *RuleError) Report() {
if len(e.items) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be if len(e.items) == 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel merged commit 555f4c0 into konveyor:main Jul 7, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Addon/analyzer integration.
2 participants