⚠️ Separate Target and RuleSet models/apis #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
reviewed
Jul 31, 2023
api/target.go
Outdated
|
|
||
| func (h TargetHandler) AddRoutes(e *gin.Engine) { | ||
| routeGroup := e.Group("/") | ||
| routeGroup.Use(Required("rulesets"), Transaction) |
There was a problem hiding this comment.
s/rulesets/targets
Also, needs to be added to the realm.
Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
Signed-off-by: Sam Lucidi <[email protected]>
jortel
reviewed
Aug 2, 2023
| @@ -268,13 +309,10 @@ func (r *RuleSet) With(m *model.RuleSet) { | |||
| // Model builds a model. | |||
| func (r *RuleSet) Model() (m *model.RuleSet) { | |||
| m = &model.RuleSet{ | |||
| Kind: r.Kind, | |||
| Name: r.Name, | |||
| Description: r.Description, | |||
There was a problem hiding this comment.
Long term we may want RuleSets to have an optional description. What do you think about leaving it?
jortel
reviewed
Aug 2, 2023
|
|
||
| func (h TargetHandler) AddRoutes(e *gin.Engine) { | ||
| routeGroup := e.Group("/") | ||
| routeGroup.Use(Required("targets"), Transaction) |
There was a problem hiding this comment.
This is probably fine and practical but expected the Transaction only on:
Create
Update
Delete
There was a problem hiding this comment.
I think we've been using it like this everywhere, and relying on the method check in the Transaction handler unless I'm mistaken.
jortel
reviewed
Aug 2, 2023
migration/v8/model/target.go
Outdated
| Name string `gorm:"uniqueIndex;not null"` | ||
| Description string | ||
| Choice bool | ||
| Labels JSON |
Signed-off-by: Sam Lucidi <[email protected]>
jortel
reviewed
Aug 2, 2023
|
|
||
| filter, err := qf.New(ctx, | ||
| []qf.Assert{ | ||
| {Field: "labels", Kind: qf.STRING}, |
There was a problem hiding this comment.
Adding name to the filter in the interest of completeness may be a nice to have but can always add later.
Signed-off-by: Sam Lucidi <[email protected]>
aufi
added a commit
to aufi/tackle2-hub
that referenced
this pull request
Aug 3, 2023
Image is not part of Ruleset anymore, removing from sample Rulesets. Related to konveyor#464 Signed-off-by: Marek Aufart <[email protected]>
jortel
pushed a commit
that referenced
this pull request
Aug 3, 2023
Image is not part of Ruleset anymore, removing from sample Rulesets. Related to #464 Signed-off-by: Marek Aufart <[email protected]>
ibolton336
added a commit
to konveyor/tackle2-ui
that referenced
this pull request
Aug 7, 2023
UI changes relating to konveyor/tackle2-hub#464 - Rename setting for ruleset/target order to match api changes - Change TS model for Ruleset to match api changes. Ruleset is now a field on the target model and can be appended to directly / read from directly when performing CRUD operations against a custom target. - Drive target card selection from label rather than ruleset/target since we no longer need to store the entire ruleset/target state in the wizard. This is because the analyzer no longer requires it to be passed in the TaskData. We are now only passing labels. This simplifies the wizard state & allows tracking of individual ruleset selection/ source selection/ target selection to be removed. - Now we can drive the select targets / select sources dropdowns on the set-options analysis wizard form from labels rather than tracking specific state for either of those. - Changes format of default sources/targets to match new hub api label format --------- Signed-off-by: ibolton336 <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.