✨ Upload files instead of multi-part form. #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
reviewed
Aug 15, 2024
mansam
approved these changes
Aug 20, 2024
aufi
approved these changes
Sep 16, 2024
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
force-pushed
the
post-analysis-files
branch
from
6e3380b
to
aeb4472
Compare
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
mansam
requested changes
Sep 26, 2024
| Reader: bytes.NewReader([]byte{}), | ||
| Name: api.FileField, | ||
| Reader: bytes.NewReader([]byte{}), | ||
| Encoding: encoding, |
There was a problem hiding this comment.
Does the Encoding field need to get set on line 532 as well?
There was a problem hiding this comment.
Yes. Good catch. Fixed.
Signed-off-by: Jeff Ortel <[email protected]>
|
Merging with CI failing because the addon-analyzer needs to merge as well. |
aufi
pushed a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Sep 27, 2024
Upload issues and deps files instead of using multi-part form. Much simpler and more easily supports the addon staging the issues and deps files on disk rather than streaming. The more atomic approach will prevent transaction deadlock which can more easily occur when the addon-analyzer builder reported an error (which it should never do). Requires: konveyor/tackle2-hub#743 --------- Signed-off-by: Jeff Ortel <[email protected]>
This was referenced Oct 1, 2024
dymurray
pushed a commit
that referenced
this pull request
Oct 11, 2024
Post a _manifest_ file instead of separate multi-part form files. Much simpler and more easily supports the addon staging the issues and deps files on disk rather than streaming. The more atomic approach will prevent transaction deadlock which can more easily occur when the addon-analyzer builder reported an error (which it should never do). The uploaded file contains markers used to delimited the documents. `^]` = `\x1D` = GS (group separator). ``` ^]BEGIN-MAIN^] --- commit: 1234 ^]END-MAIN^] ^]BEGIN-ISSUES^] --- ruleset: ruleset-1 rule: rule-1 incidents: ... ^]END-ISSUES^] ^]BEGIN-DEPS^] --- name: github.com/jboss version: 4.0 labels: - konveyor.io/language=java - konveyor.io/otherA=dog ^]END-DEPS^] ``` Flow: 1. post (upload) manifest.yaml file. 2. post `ref` to the manifest file. 3. delete manifest file. Orphaned files will be reaped. --- The binding client needed to be updated to handle different file encoding (MIME). --------- Signed-off-by: Jeff Ortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post a manifest file instead of separate multi-part form files.
Much simpler and more easily supports the addon staging the issues and deps files on disk rather than streaming. The more atomic approach will prevent transaction deadlock which can more easily occur when the addon-analyzer builder reported an error (which it should never do).
The uploaded file contains markers used to delimited the documents.
^]=\x1D= GS (group separator).Flow:
refto the manifest file.Orphaned files will be reaped.
The binding client needed to be updated to handle different file encoding (MIME).